OfficeDev / TeamsFx

Developer tools for building Teams apps
Other
425 stars 163 forks source link

refactor: build zip if plugin with placeholders #11207

Closed yuqizhou77 closed 1 month ago

yuqizhou77 commented 1 month ago

E2E: https://github.com/OfficeDev/TeamsFx/actions/runs/8461506143/job/23181498967

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 87.22%. Comparing base (33585d6) to head (34195cc). Report is 1 commits behind head on dev.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11207/graphs/tree.svg?width=650&height=150&src=pr&token=QQX8WVOEC3&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev)](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev) ```diff @@ Coverage Diff @@ ## dev #11207 +/- ## ========================================== - Coverage 87.22% 87.22% -0.01% ========================================== Files 458 458 Lines 27834 27858 +24 Branches 5593 5601 +8 ========================================== + Hits 24278 24298 +20 - Misses 1786 1788 +2 - Partials 1770 1772 +2 ``` | [Files](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11207?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev) | Coverage Δ | | |---|---|---| | [...e/src/component/driver/teamsApp/utils/telemetry.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2RyaXZlci90ZWFtc0FwcC91dGlscy90ZWxlbWV0cnkudHM=) | `100.00% <100.00%> (ø)` | | | [.../src/component/driver/teamsApp/createAppPackage.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2RyaXZlci90ZWFtc0FwcC9jcmVhdGVBcHBQYWNrYWdlLnRz) | `90.17% <90.90%> (-0.80%)` | :arrow_down: | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11207/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev)