OfficeDev / TeamsFx

Developer tools for building Teams apps
Other
425 stars 163 forks source link

fix: clean up error message from outside of TTK to minimize the risk of data privacy in telemetry collection #11226

Closed jayzhang closed 2 weeks ago

jayzhang commented 1 month ago

fix: https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/27316534

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.31%. Comparing base (5b8de10) to head (e5df49c).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11226/graphs/tree.svg?width=650&height=150&src=pr&token=QQX8WVOEC3&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev)](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11226?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev) ```diff @@ Coverage Diff @@ ## dev #11226 +/- ## ======================================= Coverage 87.30% 87.31% ======================================= Files 458 458 Lines 27973 27953 -20 Branches 5628 5621 -7 ======================================= - Hits 24422 24406 -16 + Misses 1780 1779 -1 + Partials 1771 1768 -3 ``` | [Files](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11226?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev) | Coverage Δ | | |---|---|---| | [...es/fx-core/src/component/driver/teamsApp/errors.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11226?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fcomponent%2Fdriver%2FteamsApp%2Ferrors.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2RyaXZlci90ZWFtc0FwcC9lcnJvcnMudHM=) | `69.76% <ø> (+2.45%)` | :arrow_up: | | [...fx-core/src/component/utils/ResourceGroupHelper.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11226?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fcomponent%2Futils%2FResourceGroupHelper.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L3V0aWxzL1Jlc291cmNlR3JvdXBIZWxwZXIudHM=) | `85.39% <100.00%> (+2.56%)` | :arrow_up: | | [packages/fx-core/src/core/FxCore.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11226?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fcore%2FFxCore.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29yZS9GeENvcmUudHM=) | `88.53% <100.00%> (ø)` | | | [packages/fx-core/src/core/error.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11226?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fcore%2Ferror.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29yZS9lcnJvci50cw==) | `86.04% <100.00%> (ø)` | | | [packages/fx-core/src/error/azure.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11226?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Ferror%2Fazure.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvZXJyb3IvYXp1cmUudHM=) | `100.00% <100.00%> (ø)` | | | [packages/fx-core/src/error/common.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11226?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Ferror%2Fcommon.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvZXJyb3IvY29tbW9uLnRz) | `91.27% <ø> (-0.06%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11226/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev)