search

OfficeDev / TeamsFx

Developer tools for building Teams apps
Other
427 stars 164 forks source link

fix: office add-in generator flow #11410

Closed jayzhang closed 3 weeks ago

jayzhang commented 3 weeks ago

fix:
https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/27707872 https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/27708471

Root cause: HelperMethods.downloadProjectTemplateZipFile() assume that the target folder should be empty. Otherwise, the API works incorrectly. HelperMethods.downloadProjectTemplateZipFile() will also cause a bug of file broken.

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 88.88889% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 87.74%. Comparing base (c3fe843) to head (94a405f). Report is 56 commits behind head on dev.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11410/graphs/tree.svg?width=650&height=150&src=pr&token=QQX8WVOEC3&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev)](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11410?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev) ```diff @@ Coverage Diff @@ ## dev #11410 +/- ## ========================================== + Coverage 87.72% 87.74% +0.02% ========================================== Files 485 493 +8 Lines 29280 29447 +167 Branches 5653 5679 +26 ========================================== + Hits 25685 25838 +153 - Misses 1773 1777 +4 - Partials 1822 1832 +10 ``` | [Files](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11410?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev) | Coverage Δ | | |---|---|---| | [...c/component/generator/officeAddin/helperMethods.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11410?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fcomponent%2Fgenerator%2FofficeAddin%2FhelperMethods.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2dlbmVyYXRvci9vZmZpY2VBZGRpbi9oZWxwZXJNZXRob2RzLnRz) | `86.27% <ø> (-1.37%)` | :arrow_down: | | [packages/fx-core/src/component/utils.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11410?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fcomponent%2Futils.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L3V0aWxzLnRz) | `85.93% <100.00%> (+10.26%)` | :arrow_up: | | [...e/src/component/generator/officeAddin/generator.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11410?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fcomponent%2Fgenerator%2FofficeAddin%2Fgenerator.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2dlbmVyYXRvci9vZmZpY2VBZGRpbi9nZW5lcmF0b3IudHM=) | `93.33% <50.00%> (-1.54%)` | :arrow_down: | | [...rc/component/generator/officeXMLAddin/generator.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11410?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fcomponent%2Fgenerator%2FofficeXMLAddin%2Fgenerator.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2dlbmVyYXRvci9vZmZpY2VYTUxBZGRpbi9nZW5lcmF0b3IudHM=) | `94.91% <50.00%> (-3.34%)` | :arrow_down: | ... and [24 files with indirect coverage changes](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11410/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev)