OfficeDev / TeamsFx

Developer tools for building Teams apps
Other
427 stars 164 forks source link

perf(oauth): add question model for oauth #11413

Closed KennethBWSong closed 3 weeks ago

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 91.11111% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 87.75%. Comparing base (5bc1379) to head (9b72da3). Report is 58 commits behind head on dev.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11413/graphs/tree.svg?width=650&height=150&src=pr&token=QQX8WVOEC3&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev)](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11413?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev) ```diff @@ Coverage Diff @@ ## dev #11413 +/- ## ======================================== Coverage 87.75% 87.75% ======================================== Files 493 493 Lines 29466 29508 +42 Branches 5865 5725 -140 ======================================== + Hits 25857 25895 +38 - Misses 1776 1780 +4 Partials 1833 1833 ``` | [Files](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11413?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev) | Coverage Δ | | |---|---|---| | [...kages/fx-core/src/component/driver/oauth/create.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11413?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fcomponent%2Fdriver%2Foauth%2Fcreate.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2RyaXZlci9vYXV0aC9jcmVhdGUudHM=) | `86.66% <100.00%> (+1.09%)` | :arrow_up: | | [packages/fx-core/src/question/index.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11413?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fquestion%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvcXVlc3Rpb24vaW5kZXgudHM=) | `94.73% <100.00%> (+0.29%)` | :arrow_up: | | [packages/fx-core/src/question/questionNames.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11413?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fquestion%2FquestionNames.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvcXVlc3Rpb24vcXVlc3Rpb25OYW1lcy50cw==) | `100.00% <100.00%> (ø)` | | | [packages/fx-core/src/question/other.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11413?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fquestion%2Fother.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvcXVlc3Rpb24vb3RoZXIudHM=) | `85.55% <87.50%> (+0.19%)` | :arrow_up: | ... and [11 files with indirect coverage changes](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11413/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev)