search

OfficeDev / TeamsFx

Developer tools for building Teams apps
Other
427 stars 164 forks source link

Remove webjoin=true from VS Code templates launch.json so Teams launcher is used #11434

Open therealjohn opened 3 weeks ago

therealjohn commented 3 weeks ago

To make it simpler for developers to run and debug in web OR desktop clients, the Teams launcher is the best solution right now. The launch.json in our templates currently avoids this by passing webjoin=true in the launch URL and it's unclear why.

i.e. "url": "https://teams.microsoft.com/l/app/${{local:TEAMS_APP_ID}}?installAppPackage=true&webjoin=true&${account-hint}",

We could remove this so it would be: "url": "https://teams.microsoft.com/l/app/${{local:TEAMS_APP_ID}}?installAppPackage=true&${account-hint}",

Then when you start debugging from VS Code, the default experience is to open the desktop client but you can also choose web if you prefer.

image

microsoft-github-policy-service[bot] commented 3 weeks ago

Thank you for contacting us! Any issue or feedback from you is quite important to us. We will do our best to fully respond to your issue as soon as possible. Sometimes additional investigations may be needed, we will usually get back to you within 2 days by adding comments to this issue. Please stay tuned.

MuyangAmigo commented 3 weeks ago

@therealjohn webjoin=true is added so we could enforce the account-hint to work. Otherwise if devs open desktop client and signed into a different account they will see App Not Found error and have no idea why.