OfficeDev / TeamsFx

Developer tools for building Teams apps
Other
427 stars 164 forks source link

Import flow in TTK, is pointing to Devpreview schema url with incorrect schema version (raw.githubusercontent.com) #11448

Closed therealjohn closed 1 week ago

therealjohn commented 2 weeks ago

Create an Outlook project using yo office command, with xml manifest Go to TTK and try to import the project created Check the converted manifest file.

"$schema": "https://raw.githubusercontent.com/OfficeDev/microsoft-teams-app-schema/preview/DevPreview/MicrosoftTeams.schema.json#", "manifestVersion": "devPreview",

So even for devpreview version, the schema URL should be https://developer.microsoft.com/json-schemas/teams/vDevPreview/MicrosoftTeams.schema.json

microsoft-github-policy-service[bot] commented 2 weeks ago

Thank you for contacting us! Any issue or feedback from you is quite important to us. We will do our best to fully respond to your issue as soon as possible. Sometimes additional investigations may be needed, we will usually get back to you within 2 days by adding comments to this issue. Please stay tuned.

therealjohn commented 2 weeks ago

Per Darren,

Dependency references to office-addn-project package need to be updated to version 0.8.1. Any references to office-addin-manifest-converter (I'm not sure there are any) should be updated to version 3.1.0

jayzhang commented 2 weeks ago

The manifest.json file is generated by office-addin-project package. By using office-addin-project@0.7.0, the output schema url is: https://raw.githubusercontent.com/OfficeDev/microsoft-teams-app-schema/preview/DevPreview/MicrosoftTeams.schema.json# By using office-addin-project@0.8.1, the schema url is: https://developer.microsoft.com/json-schemas/teams/v1.17/MicrosoftTeams.schema.json# So maybe @millerds can answer this question? Which version should TTK use?

therealjohn commented 2 weeks ago

@jayzhang Confirmed with the team that we want it to point to 1.17, so to answer your question: Use office-addin-project@0.8.1.

jayzhang commented 1 week ago

@therealjohn Yes. The fix will be in the next release.