OfficeDev / TeamsFx

Developer tools for building Teams apps
Other
427 stars 164 forks source link

refactor(generator): mapping user inputs to template names #11450

Closed hund030 closed 3 weeks ago

hund030 commented 3 weeks ago
  1. Mapping inputs to template names. Templates onboarding process is simplified to registering new item in the map.
  2. Customizing generator for ASP.NET SSR tab templates to keep default template generator simple.
codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 94.11765% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 87.79%. Comparing base (c3fe843) to head (24d187a). Report is 100 commits behind head on dev.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11450/graphs/tree.svg?width=650&height=150&src=pr&token=QQX8WVOEC3&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev)](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11450?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev) ```diff @@ Coverage Diff @@ ## dev #11450 +/- ## ========================================== + Coverage 87.72% 87.79% +0.07% ========================================== Files 485 496 +11 Lines 29280 29723 +443 Branches 5653 5873 +220 ========================================== + Hits 25685 26096 +411 - Misses 1773 1779 +6 - Partials 1822 1848 +26 ``` | [Files](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11450?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev) | Coverage Δ | | |---|---|---| | [...-core/src/component/generator/generatorProvider.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11450?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fcomponent%2Fgenerator%2FgeneratorProvider.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2dlbmVyYXRvci9nZW5lcmF0b3JQcm92aWRlci50cw==) | `100.00% <100.00%> (ø)` | | | [...e/src/component/generator/officeAddin/generator.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11450?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fcomponent%2Fgenerator%2FofficeAddin%2Fgenerator.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2dlbmVyYXRvci9vZmZpY2VBZGRpbi9nZW5lcmF0b3IudHM=) | `93.27% <100.00%> (-1.60%)` | :arrow_down: | | [...c/component/generator/templates/ssrTabGenerator.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11450?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fcomponent%2Fgenerator%2Ftemplates%2FssrTabGenerator.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2dlbmVyYXRvci90ZW1wbGF0ZXMvc3NyVGFiR2VuZXJhdG9yLnRz) | `100.00% <100.00%> (ø)` | | | [...component/generator/templates/templateGenerator.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11450?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fcomponent%2Fgenerator%2Ftemplates%2FtemplateGenerator.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2dlbmVyYXRvci90ZW1wbGF0ZXMvdGVtcGxhdGVHZW5lcmF0b3IudHM=) | `90.38% <100.00%> (-0.76%)` | :arrow_down: | | [...src/component/generator/templates/templateNames.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11450?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fcomponent%2Fgenerator%2Ftemplates%2FtemplateNames.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2dlbmVyYXRvci90ZW1wbGF0ZXMvdGVtcGxhdGVOYW1lcy50cw==) | `96.22% <84.61%> (-3.78%)` | :arrow_down: | ... and [52 files with indirect coverage changes](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11450/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev)