OfficeDev / TeamsFx

Developer tools for building Teams apps
Other
427 stars 164 forks source link

perf(spec-parser): do not generate response_semantics when response is empty #11453

Closed SLdragon closed 2 weeks ago

SLdragon commented 2 weeks ago

Bug 27787556: Don't generate response_semantics when response is empty

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.79%. Comparing base (6f1aa09) to head (95826b3).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11453/graphs/tree.svg?width=650&height=150&src=pr&token=QQX8WVOEC3&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev)](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11453?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev) ```diff @@ Coverage Diff @@ ## dev #11453 +/- ## ======================================= Coverage 87.79% 87.79% ======================================= Files 495 495 Lines 29726 29728 +2 Branches 5915 5818 -97 ======================================= + Hits 26099 26101 +2 Misses 1779 1779 Partials 1848 1848 ``` | [Files](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11453?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev) | Coverage Δ | | |---|---|---| | [packages/spec-parser/src/manifestUpdater.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11453?src=pr&el=tree&filepath=packages%2Fspec-parser%2Fsrc%2FmanifestUpdater.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvc3BlYy1wYXJzZXIvc3JjL21hbmlmZXN0VXBkYXRlci50cw==) | `93.10% <100.00%> (+0.06%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11453/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev)