OfficeDev / TeamsFx

Developer tools for building Teams apps
Other
427 stars 164 forks source link

refactor: spfx new generator #11497

Closed jayzhang closed 2 weeks ago

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 88.42105% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 87.80%. Comparing base (f2bd731) to head (91b8637). Report is 3 commits behind head on dev.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11497/graphs/tree.svg?width=650&height=150&src=pr&token=QQX8WVOEC3&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev)](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11497?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev) ```diff @@ Coverage Diff @@ ## dev #11497 +/- ## ========================================== - Coverage 87.80% 87.80% -0.01% ========================================== Files 496 496 Lines 29694 29767 +73 Branches 5890 5793 -97 ========================================== + Hits 26073 26137 +64 + Misses 1782 1781 -1 - Partials 1839 1849 +10 ``` | [Files](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11497?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev) | Coverage Δ | | |---|---|---| | [...-core/src/component/generator/generatorProvider.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11497?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fcomponent%2Fgenerator%2FgeneratorProvider.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2dlbmVyYXRvci9nZW5lcmF0b3JQcm92aWRlci50cw==) | `100.00% <100.00%> (ø)` | | | [...e/src/component/generator/officeAddin/generator.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11497?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fcomponent%2Fgenerator%2FofficeAddin%2Fgenerator.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2dlbmVyYXRvci9vZmZpY2VBZGRpbi9nZW5lcmF0b3IudHM=) | `93.27% <ø> (ø)` | | | [...c/component/generator/templates/ssrTabGenerator.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11497?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fcomponent%2Fgenerator%2Ftemplates%2FssrTabGenerator.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2dlbmVyYXRvci90ZW1wbGF0ZXMvc3NyVGFiR2VuZXJhdG9yLnRz) | `100.00% <ø> (ø)` | | | [...component/generator/templates/templateGenerator.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11497?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fcomponent%2Fgenerator%2Ftemplates%2FtemplateGenerator.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2dlbmVyYXRvci90ZW1wbGF0ZXMvdGVtcGxhdGVHZW5lcmF0b3IudHM=) | `90.38% <100.00%> (ø)` | | | [...src/component/generator/templates/templateNames.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11497?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fcomponent%2Fgenerator%2Ftemplates%2FtemplateNames.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2dlbmVyYXRvci90ZW1wbGF0ZXMvdGVtcGxhdGVOYW1lcy50cw==) | `96.29% <100.00%> (+0.06%)` | :arrow_up: | | [packages/fx-core/src/question/create.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11497?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fquestion%2Fcreate.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvcXVlc3Rpb24vY3JlYXRlLnRz) | `93.25% <100.00%> (+0.05%)` | :arrow_up: | | [...core/src/component/generator/spfx/spfxGenerator.ts](https://app.codecov.io/gh/OfficeDev/TeamsFx/pull/11497?src=pr&el=tree&filepath=packages%2Ffx-core%2Fsrc%2Fcomponent%2Fgenerator%2Fspfx%2FspfxGenerator.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=OfficeDev#diff-cGFja2FnZXMvZngtY29yZS9zcmMvY29tcG9uZW50L2dlbmVyYXRvci9zcGZ4L3NwZnhHZW5lcmF0b3IudHM=) | `86.88% <86.58%> (-0.17%)` | :arrow_down: |