OfficeDev / fluent-blocks

A rich component library, still in development, for providing experiences from Microsoft’s Fluent design system
https://aka.ms/fluent-blocks-storybook
MIT License
23 stars 6 forks source link

Described inputs #128

Closed thure closed 2 years ago

thure commented 2 years ago

This PR resolves #126 by introducing inputs which support an accessible description in potentially multiple ways depending on the input.

Scope is broader than I hoped

This change is much larger than anticipated because an all tests using import expect from 'expect' and .count() began failing for reasons I could not identify. Those tests needed to be refactored to use import { expect } from '@playwright/test'.

This PR also

Caveats

changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: 1844ff3311995462d667c059c5e3dd3ee43a4003

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages | Name | Type | | -------------------------- | ----- | | @fluent-blocks/react | Minor | | @fluent-blocks/schemas | Minor | | @fluent-blocks/basic-icons | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

thure commented 2 years ago

Resolving without review for now, will follow-up with feedback ahead of release to next.