search

OfficeDev / generator-office

Yeoman generator for building Microsoft Office related projects.
https://www.npmjs.com/package/generator-office
MIT License
835 stars 209 forks source link

Json template #693

Closed igor-ribeiiro closed 2 years ago

igor-ribeiiro commented 2 years ago

Creating an option to create a new JSON template for yo office. Merging in the "json" branch for now in order to not be available in master for now.

  1. Do these changes impact User Experience? (e.g., how the user interacts with Yo Office and/or the files and folders the user sees in the project that Yo Office creates)
    • [X] Yes
    • [ ] No

There is a new preview option for the generator office. Currently is in just a branch, but when merged with master it will impact the user experience

  1. Do these changes impact documentation? (e.g., a tutorial on https://docs.microsoft.com/en-us/office/dev/add-ins/overview/office-add-ins)

    • [ ] Yes
    • [X] No

    Not right now, but there will need more changes in the documentation in the future.

  2. Validation/testing performed:

    Linked and test the happy scenario of choosing the preview option.

  3. Platforms tested:

    • [X] Windows
    • [ ] Mac
millerds commented 2 years ago

Supposedly at one point the shared host branch in custom functions was referenced here in generator-office. I'm not sure how that was accomplished then, but that would be a similar situation to this.

igor-ribeiiro commented 2 years ago

This branch is ready to be revied again 😄 but github doesn't let me "request" again, so I'm sending this message @millerds

igor-ribeiiro commented 2 years ago

Ready for review again 😄

igor-ribeiiro commented 2 years ago

@millerds ready to be reviewed again 😄