search

OfficeDev / generator-office

Yeoman generator for building Microsoft Office related projects.
https://www.npmjs.com/package/generator-office
MIT License
825 stars 208 forks source link

Add note that SSO is not for production purposes #718

Closed davidchesnut closed 2 years ago

davidchesnut commented 2 years ago

Thank you for your pull request. Please provide the following information.

  1. Do these changes impact User Experience? (e.g., how the user interacts with Yo Office and/or the files and folders the user sees in the project that Yo Office creates)

    • [x ] Yes
    • [ ] No

    If Yes, briefly describe what is impacted.

The name of the SSO option is modified to note it is not for use in production.

  1. Do these changes impact documentation? (e.g., a tutorial on https://docs.microsoft.com/en-us/office/dev/add-ins/overview/office-add-ins)

    • [x ] Yes
    • [ ] No

    If Yes, briefly describe what is impacted. The SSO quickstart will need to be updated. It will also have some information indicating developers should only use this template for studying SSO, and that it does not support deployment to Azure or other cloud services.

  2. Validation/testing performed:

    Describe manual testing done.

None (just did a text change).

  1. Platforms tested:

    • [ ] Windows
    • [ ] Mac
igor-ribeiiro commented 2 years ago

Let's sync the merging of this with the change of the quickstart docs as you mentioned.

davidchesnut commented 2 years ago

I believe this pull request has been overtaken by events (see #721). Closing.