OfficeDev / generator-office

Yeoman generator for building Microsoft Office related projects.
https://www.npmjs.com/package/generator-office
MIT License
819 stars 207 forks source link

In Teams manifest option, the "resourceSpecific" AppendOnSend permission is ignored #725

Closed Rick-Kirkham closed 1 year ago

Rick-Kirkham commented 2 years ago

Prerequisites

Please answer the following questions before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

Expected behavior

When the "resourceSpecific" property has an AppendOnSend object like this:

"authorization":{
      "permissions":
        {"resourceSpecific":[
            {"name":"MailboxItem.ReadWrite.User",
             "type":"Delegated"},
            {"name":"AppendOnSend",
             "type":"Delegated"}
          ]
        }
    },

then it should create an <ExtendedPermissions> element just before the closing </VersionOverrides> element like this:

    <ExtendedPermissions>
      <ExtendedPermission>AppendOnSend</ExtendedPermission>
    </ExtendedPermissions>
</VersionOverrides>

Current behavior

The <ExtendedPermissions> element is not created.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. manually add the additional object to the "resourceSpecific" array with "name" = "AppendOnSend"
  2. start the server and sideload the add-in
  3. Go to C:\Users\YOUR_USER_NAME\AppData\Local\Temp and open the manifest.xml file. The <ExtendedOverrides> element is not there.

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

Failure Logs

Please include any relevant log snippets, screenshots or code samples here.

millerds commented 1 year ago

We've switched away from xml conversion now the json is directly supported.