OfficeDev / generator-office

Yeoman generator for building Microsoft Office related projects.
https://www.npmjs.com/package/generator-office
MIT License
819 stars 207 forks source link

Taskbar React Typescript for Outlook fails linting out of the box #730

Closed SeanKilleen closed 1 year ago

SeanKilleen commented 1 year ago

Expected behavior

Run npm run lint with no failures after fresh generation.

Current behavior

Running npm run lint yields:

HeroList.tsx 15:13 error 'children' is missing in props validation

Steps to Reproduce

millerds commented 1 year ago

Interesting that this doesn't happen on the template code directly, but does happen on the project generated from the template code.

SeanKilleen commented 1 year ago

@millerds Thanks for confirming I'm not imagining things! 😅 I'll see if I can find any more information.

millerds commented 1 year ago

Looks like you can fix this by adding "children: any;" to the HearListProps interface definition just about the class. I will add this to the template code.

millerds commented 1 year ago

https://github.com/OfficeDev/Office-Addin-TaskPane-React/pull/100#pullrequestreview-1104876488