OfficeDev / generator-office

Yeoman generator for building Microsoft Office related projects.
https://www.npmjs.com/package/generator-office
MIT License
819 stars 207 forks source link

Newest node LTS not supported #753

Closed mbrachner closed 1 year ago

mbrachner commented 1 year ago

Expected behavior

The documentation states that the newest node.js version should be used. This is at the time being version v18.13.0. When generating a template with yo office, choosing Excel Custom Functions using a JavaScript-only Runtime and JavaScript a empty template should be generated.

Current behavior

Outputs the following error:

npm WARN config cache-min This option has been deprecated in favor of `--prefer-offline`.
npm ERR! code EBADENGINE
npm ERR! engine Unsupported engine
npm ERR! engine Not compatible with your version of node/npm: excel-custom-functions-js@0.0.1
npm ERR! notsup Not compatible with your version of node/npm: excel-custom-functions-js@0.0.1
npm ERR! notsup Required: {"node":">=14 <17","npm":">=6 <9"}
npm ERR! notsup Actual:   {"npm":"8.19.3","node":"v18.13.0"}

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\markusb\AppData\Local\npm-cache\_logs\2023-01-11T12_06_01_050Z-debug-0.log

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Install Node js version v18.13.0
  2. yo office

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

Failure Logs

2023-01-11T12_06_01_050Z-debug-0.log

millerds commented 1 year ago

We are currently in the process of validating the script and templates continue to work with the new LST version of node.

BobFrankston commented 1 year ago

Tried on 19.5.0. Since the main repository for ScriptLab hasn't been updated in 2yrs and is still marked V1, I want to make sure it is still being supported and updated.

image

millerds commented 1 year ago

v19 is the current version of node while the LTS version of node is v18 (https://nodejs.org/en/). We support v18.

BobFrankston commented 1 year ago

I look forward to a version for 19 -- do you know when it might be supported? Is Scriptlab itself being actively supported? I want to make more use of it but I'm wary.

millerds commented 1 year ago

According nodejs.org the even numbered versions are promote to LTS and the odd number versions are not. They release a new LTS version (the next one being v20) in the fall and that's when we will look at moving forward.

https://github.com/nodejs/release#release-schedule