search

OfficeDev / generator-office

Yeoman generator for building Microsoft Office related projects.
https://www.npmjs.com/package/generator-office
MIT License
815 stars 207 forks source link

Add one step samples for Word and Excel in Yeoman #794

Closed richard6094 closed 1 month ago

richard6094 commented 7 months ago

Thank you for your pull request. Please provide the following information.

  1. Do these changes impact User Experience? (e.g., how the user interacts with Yo Office and/or the files and folders the user sees in the project that Yo Office creates)

    • [ -] Yes
    • [ ] No

    If Yes, briefly describe what is impacted. There will be 2 more options for users' choices: image Users could 1-step to get the sample add-in code, edit it and automatically launch.

  2. Do these changes impact documentation? (e.g., a tutorial on https://learn.microsoft.com/en-us/office/dev/add-ins/overview/office-add-ins)

    • [- ] Yes
    • [ ] No

    If Yes, briefly describe what is impacted. There will be an one-line command added for users to use the scripts in yeoman.

  3. Validation/testing performed: We have tested the parameters, options and error handlings

  4. Platforms tested:

    • [ - ] Windows
    • [ ] Mac
millerds commented 7 months ago

If you want to experiment with a yeoman generator in ways that are very different from the established patterns here than maybe you should consider a separate yeoman plug-in (possibly forked from this code).

On top of that . . . if it is something that doesn't use the generator option, then why are you using yeoman in the first place? The same thing could be accomplished with through other means (like doing more in the bath file).