OfficeDev / generator-office

Yeoman generator for building Microsoft Office related projects.
https://www.npmjs.com/package/generator-office
MIT License
815 stars 207 forks source link

The --prerelease switch doesn't fetch prerelease branch when JavaScript chosen #798

Closed Rick-Kirkham closed 7 months ago

Rick-Kirkham commented 7 months ago

Prerequisites

Please answer the following questions before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

Expected behavior

Install latest version of Yo Office.

Run yo office --prerelease. When prompted, choose the Taskpane option. When prompted, choose JavaScript. Pick any Office application and give the project any name.

The generated project should have the code from the yo-office-prerelease branch of Office-Addin-Taskpane repo.

UPDATE: I just noticed that you merged https://github.com/OfficeDev/generator-office/pull/795. So, it should have fetched from master. But the essential problem is still there. It's fetching from yo-office branch, but only when JavaScript is chosen. Works fine if I choose TypeScript.

Current behavior

The project has the code from the yo-office branch.

NOTE: Choosing TypeScript, instead of JavaScript, works as expected.

Steps to Reproduce

See above.

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

Failure Logs

Please include any relevant log snippets, screenshots or code samples here.

Rick-Kirkham commented 7 months ago

My bad. I forgot that JavaScript is a separate repo.