search

OfficeDev / generator-office

Yeoman generator for building Microsoft Office related projects.
https://www.npmjs.com/package/generator-office
MIT License
815 stars 207 forks source link

Combine xml and json template repo references #813

Closed millerds closed 4 months ago

millerds commented 4 months ago

Thank you for your pull request. Please provide the following information.

Point to the single template repo branch for both the xml manifest project and the json project. Also stopped updating the manifest (GUID and title) here and left that for the template convert script. Also fixed the security alert for ip *.

  1. Do these changes impact User Experience? (e.g., how the user interacts with Yo Office and/or the files and folders the user sees in the project that Yo Office creates)
    • [x] Yes
    • [ ] No

There is now the possibility of getting json manifest project or xml manifest project based on the same template

  1. Do these changes impact documentation? (e.g., a tutorial on https://learn.microsoft.com/en-us/office/dev/add-ins/overview/office-add-ins)
    • [x] Yes
    • [ ] No

Documentation for creating json projects will need to be updated to the new set of questions.

  1. Validation/testing performed:

    Ran automated tests. Also generated projects for json and xml manually. Ran one of those projects as well.

  2. Platforms tested:

    • [x] Windows
    • [ ] Mac