OfficeDev / generator-office

Yeoman generator for building Microsoft Office related projects.
https://www.npmjs.com/package/generator-office
MIT License
815 stars 207 forks source link

Update zip library #827

Closed millerds closed 1 month ago

millerds commented 1 month ago

Thank you for your pull request. Please provide the following information.


Switched from unzipper to adm-zip which doesn't have problems with certain versions of node.

  1. Do these changes impact User Experience? (e.g., how the user interacts with Yo Office and/or the files and folders the user sees in the project that Yo Office creates)

    • [ ] Yes
    • [x] No
  2. Do these changes impact documentation? (e.g., a tutorial on https://learn.microsoft.com/en-us/office/dev/add-ins/overview/office-add-ins)

    • [ ] Yes
    • [x] No
  3. Validation/testing performed:

Installed on a different machine with version of node that exhibited the zip problem and created test projects. Ran automated tests as well

  1. Platforms tested:

    • [x] Windows
    • [ ] Mac