search

OfficeDev / generator-office

Yeoman generator for building Microsoft Office related projects.
https://www.npmjs.com/package/generator-office
MIT License
825 stars 208 forks source link

Create a new option to initialize an NAA SSO (preview) project #832

Closed pkkj closed 2 months ago

pkkj commented 2 months ago

Create a new option to initialize an NAA SSO (preview) project in generator-office. Only TypeScript is supported.

Thank you for your pull request. Please provide the following information.

  1. Do these changes impact User Experience? (e.g., how the user interacts with Yo Office and/or the files and folders the user sees in the project that Yo Office creates)

    • [x] Yes
    • [ ] No

    If Yes, briefly describe what is impacted.

  2. Do these changes impact documentation? (e.g., a tutorial on https://learn.microsoft.com/en-us/office/dev/add-ins/overview/office-add-ins)

    • [ ] Yes
    • [X] No

    If Yes, briefly describe what is impacted.

  3. Validation/testing performed:

The change is tested locally by replacing npm installation file with "yo office" command. The UI menu selector and command line are both tested.

Also test the sample project for Win32 and Office Online.

  1. Platforms tested:

    • [X ] Windows
    • [ ] Mac
millerds commented 2 months ago

/azurepipelines run

azure-pipelines[bot] commented 2 months ago
Azure Pipelines successfully started running 1 pipeline(s).
millerds commented 2 months ago

@pkkj is there any reason Outlook isn't also supported?

pkkj commented 2 months ago

@pkkj is there any reason Outlook isn't also supported?

We are still working on the sample. Other than taskpane, Outlook has launch event.

millerds commented 2 months ago

@pkkj is there any reason Outlook isn't also supported?

We are still working on the sample. Other than taskpane, Outlook has launch event.

Fair enough. The template isn't required to include a launch event. Currently there isn't a template with a launchevent sample in it, but that should be in the works. It's up to you what you include especially since it's in preview.

AlexJerabek commented 2 months ago

@pkkj, is there a reason we don't want to document this option? We have a quick start for the yo office SSO path.

Also, sorry to be pedantic, but adding a new option does change the UX (PR template question 1).

pkkj commented 2 months ago

@pkkj, is there a reason we don't want to document this option? We have a quick start for the yo office SSO path.

Also, sorry to be pedantic, but adding a new option does change the UX (PR template question 1).

I think we will have it documented when the generator is ready. I will discuss with David about it. Thanks.