OfficeDev / microsoft-teams-apps-champion-management

Champion Management Platform is a custom Teams app that enables organizations to onboard and maintain champions/ SME in their organization in Teams.
MIT License
125 stars 48 forks source link

Champion list username fields reversed #116

Closed LisaJo48 closed 1 year ago

LisaJo48 commented 1 year ago

Testing the interface and found this issue. my last name was automatically entered into the FirstName field and my first name in the LastName field. image

I've tried reinstalling to be sure I hadn't done something to cause it in my testing and it is still the case.

v-saikirang commented 1 year ago

Hi @LisaJo48,

Thanks for your interest in the app and reaching out to us.

This is a known issue with the app. This happens if the display name in your organization is configured as "LastName FirstName" in the Azure Active Directory. And I assume this is the case with you as well. We have plans to change this behavior in upcoming releases. Please watch out for the updates in git hub.

Please let me know if you need more information. Else we would like to close this ticket for now. Thanks.

LisaJo48 commented 1 year ago

When? This is a pretty front-and-center/first impression problem for us. We’re to deploy this by December. I need to be able to tell Leadership WHEN it will be fixed---not just that it will. Thanks.

v-saikirang commented 1 year ago

Hi @LisaJo48,

We are tentatively planning the next release in early November and we will plan to include the change for this scenario as well in that release. And I see that you also wanted to to make some customizations to the app. Please note that customization requires an understanding on SPFX, React and type script. But we will not be able to support the custom versions of the app and our future upgrades to the app in git hub will not pass over to your custom version and those code upgrades will have to made manually to your custom version. Please let us know if you need more information.

Thanks.

LisaJo48 commented 1 year ago

That will be great timing. Thanks for giving me that information so that I can set that issue aside in anticipation of the fix.

LisaJo48 commented 1 year ago

Hello @v-saikirang. I am checking in to see if this fix will be included in the November release. This fix is critical to our ability to go Live with this tool in December.

And will this fix also display the champions first AND last name in the Top Champions: My Rank list. Right now it just shows last name which is insufficient. I wondering if, when the first/last name issue mentioned here is corrected, if the Top Champions list is going to only show the champions first name....which is also insufficient: both first and last needs to be displayed here, too.

v-saikirang commented 1 year ago

Hi @LisaJo48,

This issue will be part of our next release. Please note that we don't have a fixed date yet for the release. But currently we are targeting either end of November or early December which is tentative.

The Leaderboard ideally should display both first name and last name but since you have the first name and last name reversed it should at least show in "Last Name First Name". If that's not the case please share a screenshot of Leaderboard and contents of the "Members List" in Share Point site.

And after that fix the new champions will be added properly but the data for old champions which are already in "Members List" will have to fixed either manually in the list or for those users only it will shows reversed names in Leaderboard.

Thanks.

LisaJo48 commented 1 year ago

These images show how the app saves and displays the information submitted for the nominee (by other champions) or added member (by a manager).

image image image image

v-saikirang commented 1 year ago

Hi @LisaJo48,

Thanks for the screenshots.

So I see that the Leader Board and the side bar is showing in the format of "FirstName LastName". But since you have Display Name set as "LastName FirstName" in your AD the values are reversed in the SP list while saving it. We have fixed this issue now so that whenever a new champion is added the values are stored in the SP list in the correct order. But this will take effect only for new entries after the upgrade. Any old values already stored in list will need to be changed manually if any. So the next release should handle your scenario. Please let me know if you need more information. Thanks.

LisaJo48 commented 1 year ago

If I manually reverse the info that is in the Members List first and last name fields now so that they make sense to the end user when we go Live (which, unfortunately, sounds like that will be before the release of the fix for this), will those changes still be correct after the fix is released or will I have to reverse them back?

v-saikirang commented 1 year ago

Hi @LisaJo48,

If you manually reverse info in members List now you don't have to reverse them back after the upgrade.

Please let me know if you need more information here.

Thanks.

LisaJo48 commented 1 year ago

Thank you. It's so helpful to know what 'maintenance' I'm going to need to do as we deploy this.