OfficeDev / microsoft-teams-apps-champion-management

Champion Management Platform is a custom Teams app that enables organizations to onboard and maintain champions/ SME in their organization in Teams.
MIT License
125 stars 48 forks source link

App icon won't change #134

Closed LisaJo48 closed 1 year ago

LisaJo48 commented 1 year ago

I have replaced the star icon with one of our own with properties of 32x32 pixels and .jpg. The icon in the app remains the star. I even removed it from the CMP Logo library, deleted the browser history, cleared all cache but it still shows the star. What am I doing wrong?

image image

LisaJo48 commented 1 year ago

Update. Now one star icon is missing but the other is not and my logo is not in either spot. image

However, for another user, both star icons are still visible. I've cleared cached several times to no avail. image

What I need, at the least, is that the logo right above the Welcome banner is updated to ours.

v-prigunasek commented 1 year ago

Hi @LisaJo48 ,

Can you please rename the image to AppLogo.jpg in the CMP Logo library? Please refer the specifications in the document - https://github.com/OfficeDev/microsoft-teams-apps-champion-management/wiki/Solution-Overview#manage-app-logo

After renaming the image, please clear the cache and try again. Thanks!

LisaJo48 commented 1 year ago

NEVER caught that as I read the instructions over and over. Never crossed my mind to change the original's name and reuse it for the new one. So Sorry. Thanks!

So, is it correct that only one start icon has changed but not the others? image

v-saikirang commented 1 year ago

Hi @LisaJo48,

The Icon you pointed is coming from Teams App Store. So it cannot be changed from within the app. You will have to perform additional steps to change the icon in Teams store too:

1) Delete the app from "Manage Apps" section in "Teams Admin center". Note that this step will not make any changes to your Share Point site. 2) Download the below 3 files from the Teams Folder in GitHub Repo. image 3) Replace the 2 image files with your own icons as per guidelines specified here. 4) Create a new ZIP file with the name "Champion Management Platform" with 3 files including 2 icons and manifest file. Note that the final zip package should contain only these 3 files without any nested folders. 5) Upload the publish the zip file from "Manage Apps" section in "Teams Admin Center" 6) Close browsers and reopen new browser after 5-10 mins to clear out cache.

Please let us know if you need more information. Thanks.

LisaJo48 commented 1 year ago

Thank you but, before engaging on the next change, I have an interesting observation. In the TEAMS via browser (Edge), my newest icon is showing (a yellow logo with a black bar underneath it) where I would expect it to show but, the Star icon is not showing in the other two locations mentioned above. However, in TEAMS on desktop, it shows the previous icon I'd tested, instead of the newest one, and the Star icon does show in the other two locations.

image

I have cleared the browser cache (images and files), refreshed several times, closed/reopened, and rebooted my computer. image

So far, no change.

However, doing the same steps in the Chrome browser, works as expected: image

Firefox is also correct showing the Star icon in the two expected locations. I cannot test for Safari.

FYI: the Star icon was also in the Edge browser, as expected, until about 3am Wednesday. After that, it has looked like this. I made no changes other than upload a new image file and rename it, per instructions, to AppLogo.jpg

v-saikirang commented 1 year ago

Hi @LisaJo48,

Most of the times it's due to cache issues. Teams client would usually take some time to sync in changes. Please let me know if you still the issue. Thanks.

LisaJo48 commented 1 year ago

Thanks @v-saikirang. I'll keep an eye on it and re-open this if it reoccurs or doesn't refresh/fix on its own.