search

OfficeDev / microsoft-teams-apps-company-communicator

Company Communicator app template
MIT License
331 stars 403 forks source link

Unable to send messages after 5.5.2 update #1610

Open eanthonyq opened 6 days ago

eanthonyq commented 6 days ago

We updated to 5.5.2 on October 15th and haven't been able to send messages from the Application since.

I've reviewed Issues #1061, #1551, #1608 and #1593 and tried the steps taken in them as the errors are similar to what was referenced in them.

  1. Validated all the Environment variables from the installation guide in the App Service Configuration as well as the 3 Function Apps.
  2. App Registration IDs and associated Secrets Validated GraphAppId -- GraphAppPassword AzureAd:ClientId -- AzureAd:ClientSecret UserAppId -- UserAppPassword AuthorAppId -- AuthorAppPassword
  3. Reviewed App Registration Manifests
  4. Redeployed 5.5.2 Client and Author Apps
  5. Resyncs done to GIT repository
  6. Restarts of web applications/functions

The errors I'm seeing in the Failures reports are 401 errors to a few API calls: GET /api/draftnotifications/scheduledDrafts GET /api/draftnotifications/ GET /api/sentnotifications

As well as OrchestrationFailures in the SyncRecipientsOrchestrator Function.

Example OrchestrationFailures Error: Exception while executing function: SyncRecipientsOrchestrator Orchestrator function 'SyncRecipientsOrchestrator' failed: The activity function 'BatchRecipientsActivity' failed: "Object reference not set to an instance of an object.". See the function execution logs for additional details.

From the resolved tickets this seems to be a secret related issue, but we've checked a few times that the active secrets in the KeyVault for the App Registrations are valid.

Any guidance would be greatly appreciated.

v-jaygupta commented 3 days ago

Hello @eanthonyq , Thanks for reaching out to us! Could you please go thorugh the v5 migration process as mentioned here.

Also, please share deployment status screenshots of all the Function apps and App service from the deployment center. Here is the reference for App service status. Please do the same for 3 function apps(Data Function, Send Function, Prep Function) image

eanthonyq commented 2 days ago

Hi @v-jaygupta,

I've gone back through 5.x upgrade steps.

  1. Confirmed the .NET Version AppService_GenSettings

  2. Confirmed Runtime Versions for functions dataFunction prepFunction Function

  3. Confirmed Organization specific configuration settings for Web Application and Website Default Node setting WebAppConfig WebsiteDefualtNode

  4. Resynced Web Apps and 3 Function Apps WebAppDeploy DataFunctionDeploy PrepFunctionDeploy FunctionDeploy

It looks like the Function Apps were not at the same version as the Web Application. They all look to be at the same versions now.

  1. Restarted Web Application and Function Apps

After their restarts I confirmed in the Author Application in Teams that all organization specific configurations were displaying and configured I was able to delete messages from the Application.

Resending a message to users now produces the same Orchestrator Error but there is additional Warning Information. That was not displayed before. The actual being displayed in the Warning is the App ID for the UserAppID App Setting in the Web Application and 3 Function App Environmental Variables.

Errors Failed to prepare the message for sending:The orchestrator function 'SyncRecipientsOrchestrator' failed: "The activity function 'BatchRecipientsActivity' failed: "Object reference not set to an instance of an object.". See the function execution logs for additional details.". See the function execution logs for additional details. Warnings Failed to get members for team @thread.tacv2: Failed to acquire token for client credentials. (A configuration issue is preventing authentication - check the error message from the server for details. You can modify the configuration in the application registration portal. See https://aka.ms/msal-net-invalid-client for details. Original exception: AADSTS7000215: Invalid client secret provided. Ensure the secret being sent in the request is the client secret value, not the client secret ID, for a secret added to app ''. Trace ID: Correlation ID: Timestamp: 2024-11-11 14:24:27Z)

tiwariShiv7 commented 2 days ago

Hi @eanthonyq, From the screenshot it seems like you are using a custom repository here. Can you please recheck and send screenshot of Deployment Center of any of the function app / Web app ?

Please note that if you are not using Official version of the Company Communicator, it will be out of our Support Scope as per our Support Policy

eanthonyq commented 1 day ago

Hi @tiwariShiv7, It seems like there are 2 repository URLs being used across the Web App and 3 Function Apps.

Web App and the -data-fuction are using: https://github.com/OfficeDev/microsoft-teams-company-communicator-app.git WebAppDC DataFunctionDC

The -prep-function and the -function are using: https://github.com/OfficeDev/microsoft-teams-apps-company-communicator PrepFunctionDC FunctionDC

When I follow the link to the Branch from the Deployment Center on any of those I am taken to the same URL: https://github.com/OfficeDev/microsoft-teams-apps-company-communicator

If this is not the official version could you help me with the steps to link it to the correct one?

tiwariShiv7 commented 1 day ago

The correct URL is https://github.com/OfficeDev/microsoft-teams-company-communicator-app.git Okay I can see in the history of Code, there are commits from Derek. Please allow me little time ~36 hours. I'll get back to you within this time