OfficeDev / microsoft-teams-apps-company-communicator

Company Communicator app template
MIT License
329 stars 401 forks source link

Client secret not updating #943

Closed Scheiderichv094 closed 1 year ago

Scheiderichv094 commented 1 year ago

Good morning,

Our secret for Company Communicator v4 was due to expire 1/6/2023. Our M365 team updated the secret in AppSettings, KeyVault, Azure Bot, AuthorAppPassword, and Graph App Password. Now we are not able to use Company Communicator in MS Teams. Errors we get in Teams are, "Oooops! An unexpected error seems to have occurred." and "Permissions needed. Ask your IT admin to enable this option for you." After looking in AAD, they saw logs on users that say, "Invalid client secret provided. Ensure the secret being sent in the request is the client secret value, not the client secret ID. for a secret add to app '(identifier)'

Are you able to chat via email? We use this org wide to broadcast updates for Major Incidents. Scheiderichv@outlook.com

gsv022 commented 1 year ago

Hi @Scheiderichv094 , Thanks for raising the query. Could you please respond to the below queries.

Scheiderichv094 commented 1 year ago

Thank you replying back! Adding my work email and the M365 engineer that has been helping me.


From: Sai Venkat @.> Sent: Thursday, December 29, 2022 12:57:45 AM To: OfficeDev/microsoft-teams-apps-company-communicator @.> Cc: Victor S. @.>; Mention @.> Subject: Re: [OfficeDev/microsoft-teams-apps-company-communicator] Client secret not updating (Issue #943)

Hi @Scheiderichv094https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FScheiderichv094&data=05%7C01%7C%7Cef54c1ec5ca348de4aa608dae9619b7a%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638078902669470727%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=IUxcD9CXMxJWyXJi1%2BiBhD08R9nXhB57fgdRUSYa3ds%3D&reserved=0 , Thanks for raising the query. Could you please respond to the below queries.

[image]https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F98143492%2F209909182-2305ad53-3365-42ef-8085-38488f4ec08e.png&data=05%7C01%7C%7Cef54c1ec5ca348de4aa608dae9619b7a%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638078902669470727%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=EQLhS1vVwAuaC8wmJAQsdiI3eZ6QmcjSojzH6FXCzZE%3D&reserved=0

— Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FOfficeDev%2Fmicrosoft-teams-apps-company-communicator%2Fissues%2F943%23issuecomment-1367089002&data=05%7C01%7C%7Cef54c1ec5ca348de4aa608dae9619b7a%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638078902669470727%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=mTMB6XE5UkQT1dTSoSppt0YgAr6BbK9LhnfIRz7TMgk%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA2MQQASI4ZBK5BN37IJFDALWPUR5TANCNFSM6AAAAAATLKGLAM&data=05%7C01%7C%7Cef54c1ec5ca348de4aa608dae9619b7a%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638078902669470727%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=HYb6w5BS%2BvOeHiRJmnXT6TyEXAViROxqDvEQDOOFeag%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

Scheiderichv094 commented 1 year ago

Good morning,

We believe we have version 4 but it has been half a year since we installed it. Is there where a way to check to see what version we have? Also, our M365 engineers made sure to copy the value and not the ID and double checked. Are we able to schedule a screenshare and walk us through it?

Scheiderichv094 commented 1 year ago

Any update?

Scheiderichv094 commented 1 year ago

Any update on being able to schedule a meeting?

gsv022 commented 1 year ago

Hi @Scheiderichv094 , Please share your availability for today(02/01/23) or tomorrow(03/01/23) so that we can schedule a call to discuss the issue.

Thank you

Scheiderichv094 commented 1 year ago

I am on vacation until January 9th 2023. Are you able to schedule a time Tuesday, January 3rd with Ricardo Thomas @.*** He is the one that helped me deploy it and renewed the secret.


From: Sai Venkat @.> Sent: Sunday, January 1, 2023 11:02:40 PM To: OfficeDev/microsoft-teams-apps-company-communicator @.> Cc: Victor S. @.>; Mention @.> Subject: Re: [OfficeDev/microsoft-teams-apps-company-communicator] Client secret not updating (Issue #943)

Hi @Scheiderichv094https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FScheiderichv094&data=05%7C01%7C%7C815696913fcf48f0423d08daec763202%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638082289647261881%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=7N9Tzf8fv1nlFNcJB9er%2BWwpllrc0VOM81ACx3R0juc%3D&reserved=0 , Please share your availability for today(02/01/23) or tomorrow(03/01/23) so that we can schedule a call to discuss the issue.

Thank you

— Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FOfficeDev%2Fmicrosoft-teams-apps-company-communicator%2Fissues%2F943%23issuecomment-1368637182&data=05%7C01%7C%7C815696913fcf48f0423d08daec763202%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638082289647261881%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=LegKL9A94PIFVebuqLRTa2TaVgTAagQA%2FnF5w%2FyciVk%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FA2MQQARYILYCLDBPI3BYAEDWQJHOBANCNFSM6AAAAAATLKGLAM&data=05%7C01%7C%7C815696913fcf48f0423d08daec763202%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638082289647261881%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=kbb46ZHVc0l6kttT%2FwLxvcH0IP17SkdU8YSHSP65kyc%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

gsv022 commented 1 year ago

@Scheiderichv094 , This id is masked could you please share the actual id

image
Scheiderichv094 commented 1 year ago

Ricardo.thomas@osumc.edu

Scheiderichv094 commented 1 year ago

Are you able to see it now?

gsv022 commented 1 year ago

Thanks for sending it. 3pm-4pm IST tomorrow, does this time work for you?

Scheiderichv094 commented 1 year ago

We are eastern time so that would be 4:00-5:00am. Anything later in the day?

gsv022 commented 1 year ago

Please let us know the time that the user is available on that day so that we can schedule the call accordingly.

Scheiderichv094 commented 1 year ago

Ricardo is available from 8am to 5pm eastern time today

gsv022 commented 1 year ago

Thanks for confirming. We will be sending out the meeting invite in a while

Scheiderichv094 commented 1 year ago

Thanks for confirming. We will be sending out the meeting invite in a while

Thank you! Let me know if you need further details.

gsv022 commented 1 year ago

We have sent a meeting invite already. Waiting for the user to attend

Scheiderichv094 commented 1 year ago

We have sent a meeting invite already. Waiting for the user to attend

He said he will be free after 8:30am

gsv022 commented 1 year ago

We started a conversation internally on MS Teams platform with Ricardo.

Scheiderichv094 commented 1 year ago

We started a conversation internally on MS Teams platform with Ricardo.

Great!

Scheiderichv094 commented 1 year ago

We started a conversation internally on MS Teams platform with Ricardo.

Great!

He said he started the Teams meeting and is waiting for you

Scheiderichv094 commented 1 year ago

We started a conversation internally on MS Teams platform with Ricardo.

Great!

He said he started the Teams meeting and is waiting for you

You have ricardo.thomas@osumc.edu correct? What is your email so he can invite you?

Scheiderichv094 commented 1 year ago

We started a conversation internally on MS Teams platform with Ricardo.

Great!

He said he started the Teams meeting and is waiting for you

You have ricardo.thomas@osumc.edu correct? What is your email so he can invite you?

Are you guys able to meet today? Ricardo said you never joined

v-royavinash commented 1 year ago

We are closing out the issue as messages were sent successfully to the ~600 intended users. Please reach out to us if you face any issue in future

albert-widjaja commented 5 months ago

Can we use the automated Client secret rotation with this https://learn.microsoft.com/en-us/azure/key-vault/secrets/tutorial-rotation ?

or do we still have to manually update the client secret at the company communicator key vault before it expires?