OfficeDev / microsoft-teams-apps-icebreaker

Icebreaker is an open-source app for Microsoft Teams that helps the whole team get closer by pairing members up every week at random to meet for coffee, burgers, pizza, or a walk around the block.
MIT License
174 stars 206 forks source link

Failed to create or update the app in Azure Active Directory. Exiting... #252

Open darkenizer opened 2 years ago

darkenizer commented 2 years ago

When I try to install the icebreaker bot via the script I always get the error shown in the screenshot. Unfortunately without further specification why the error occurred.

My user has global admin rights.

Can someone help?

icebreaker_fehler

gsv022 commented 2 years ago

Hi @darkenizer ,

Could you please go for the manual deployment procedure to keep yourself unblocked. Meanwhile we are checking the issue. Please let us know if you are facing the issues while doing manual deployment.

Thank you.

v-royavinash commented 2 years ago

@darkenizer, Let us know if the manual deployment worked for you?

taurheim commented 2 years ago

I had the same issue - it looks like the creation of the app is not successful but is being treated as such (I also get the "XX registered successfully" message. When I tried using an existing app the rest of the script worked fine

RequieM88 commented 1 year ago

@darkenizer @taurheim

The issue is that the AZ module has changed. I changed the deploy.ps1 to be:

#Update
if($MultiTenant -eq $true) {
    az ad app update --id $app.appId --sign-in-audience AzureADMultipleOrgs --enable-access-token-issuance $AllowImplicitFlow
} else {
    az ad app update --id $app.appId --sign-in-audience AzureADMyOrg --enable-access-token-issuance $AllowImplicitFlow
}
#Create
if($MultiTenant -eq $true) {
    az ad app create --display-name $appName --sign-in-audience AzureADMultipleOrgs --enable-access-token-issuance $AllowImplicitFlow
} else {
    az ad app create --display-name $appName --sign-in-audience AzureADMyOrg --enable-access-token-issuance $AllowImplicitFlow
}

Which resolves the issue.

williamaherman commented 8 months ago

@RequieM88 can you call out where you specifically are updating the code?

RequieM88 commented 8 months ago

@williamaherman

https://github.com/OfficeDev/microsoft-teams-apps-icebreaker/blob/main/Deployment/deploy.ps1

Replace line 204 for update Replace line 217 for create