search

OfficeDev / microsoft-teams-apps-icebreaker

Icebreaker is an open-source app for Microsoft Teams that helps the whole team get closer by pairing members up every week at random to meet for coffee, burgers, pizza, or a walk around the block.
MIT License
174 stars 206 forks source link

deploy.ps1 error #291

Closed Hennericho closed 1 year ago

Hennericho commented 1 year ago

Hi all, There is an issue in the deply.ps1 file. It is using outdated and unsupported parameters when creating the app. On line number 204 & 217 there is a command: az ad app create --display-name $appName --available-to-other-tenants $MultiTenant --oauth2-allow-implicit-flow $AllowImplicitFlow

This needs to be be changed to: az ad app create --display-name $appName --sign-in-audience AzureADMultipleOrgs

gsv022 commented 1 year ago

Hi @Hennericho , Thanks for the suggestion. We will look into the inputs suggested and verify it from our end. Then will do the necessary

v-royavinash commented 1 year ago

@Hennericho To avoid errors during deployment, we recommend using Azure CLI version 2.30.0. In future releases, we will address the highlighted issue and provide support for the latest Azure CLI version, which in turn utilizes the latest parameters.

ghost commented 1 year ago

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.