search

OfficeDev / microsoft-teams-faqplusplus-app

DEPRECATED - This repository contains a deprecated version of the FAQ Plus app template. Please see the README file for more details and a link to the new repository
MIT License
48 stars 49 forks source link

Vansi16/ team-kb-welcome-changes #22

Closed anuragysingh closed 5 years ago

anuragysingh commented 5 years ago

Merged review comments for below PR's along with review comment fix:

  1. 9 - team edit, #13 - knowledgebase store , #15 - lazy loading, #20 - teamid fix and welcome message

  2. Error handling has been moved from controller to provider
  3. One table is updated for team, kb and welcome message instead of 3 separate tables as earlier approach
  4. Constants has been updated to help in identify from which screen the requests are coming
anuragysingh commented 5 years ago

@aosolis - could you please help by reviewing the PR

aosolis commented 5 years ago

@suramn Can you review this too-- this will affect your work.