search

OfficeDev / microsoft-teams-faqplusplus-app

DEPRECATED - This repository contains a deprecated version of the FAQ Plus app template. Please see the README file for more details and a link to the new repository
MIT License
48 stars 49 forks source link

Teams link not working in Bot config App #92

Closed SebastianSchuetze closed 4 years ago

SebastianSchuetze commented 4 years ago

Hi,

I encountered that the teams link ID that is provided does not work properly.

In the controler HomeControler.cs the link is parsed with an ending string of %40thread.skype or @thread.skype

https://github.com/OfficeDev/microsoft-teams-faqplusplus-app/blob/08a69787255e6fc53984b83a8ddc3e28f87f0e38/Source/Microsoft.Teams.Apps.FAQPlusPlus.Configuration/Controllers/HomeController.cs#L23

but in fact the url of the team link you get has chaned to @thread.tacv2. The code shoulkd be changed. I could mitigate from it by just using the string that is trying to pars by using @thread.skype instead of @thread.tacv2.

SebastianSchuetze commented 4 years ago

PR #93 is fixing it