search

OfficeDev / microsoft-teams-library-js

JavaScript library for use by Microsoft Teams apps
https://docs.microsoft.com/microsoftteams/platform/
Other
431 stars 199 forks source link

2.4.0 does not compile #1382

Closed vvolodin closed 2 years ago

vvolodin commented 2 years ago

My app stopped compiling after updating teams-js to 2.4.0:

Error: node_modules/@microsoft/teams-js/dist/MicrosoftTeams.d.ts:6:90 - error TS2307: Cannot find module '@fluidframework/azure-client' or its corresponding type declarations.

6 import type { AzureConnectionConfig, AzureContainerServices, ITelemetryBaseLogger } from '@fluidframework/azure-client';



Error: node_modules/@microsoft/teams-js/dist/MicrosoftTeams.d.ts:7:55 - error TS2307: Cannot find module '@fluidframework/fluid-static' or its corresponding type declarations.

7 import type { ContainerSchema, IFluidContainer } from '@fluidframework/fluid-static';
ghost commented 2 years ago

Hi vvolodin! Thank you for bringing this issue to our attention. We will investigate and if we require further information we will reach out in one business day. Please use this link to escalate if you don't get replies.

Best regards, Teams Platform

Meghana-MSFT commented 2 years ago

Did deleting node modules and package-lock.json help? Meanwhile could you please share the sample/minimal code that you are trying. So that we can check for repro at our end as well.

nwojod-MSFT commented 2 years ago

@vvolodin the team is working on resolving this issue. We will update you once the issue is resolved.

Stevenic commented 2 years ago

@vvolodin we're working on a fix but we're trying to better understand the nature of the issue. Can you tell me, does your app pull in any separate packages that have a dependency on teams-js? This error isn't occurring for all applications and we have at least one large complex application with nested dependencies where it is occurring so trying to isolate the trigger.

vvolodin commented 2 years ago

No, teams-js is a direct dependency in my project, and judging by how it only occurs a couple of times in package-lock.json there are no other libraries depending on it. I do updates frequently (angular, ngrx, etc.) and very rarely have to remove my node_modules.

jadahiya-MSFT commented 2 years ago

@vvolodin We've rolled back version 2.4.0 to 2.3.0 (latest now points to 2.3.0), while we work to fix this in a future release. Please let me know if there are any errors with the rolled back version. Thanks.

nwojod-MSFT commented 2 years ago

@vvolodin we have fixed this and rolled out version 2.4.1. Please update your sdk to the latest version and let us know if you are still experiencing this issue. Thanks.

nwojod-MSFT commented 2 years ago

Please reopen issue if still experiencing the error.

ghost commented 2 years ago

Tell us about your experience!

Hi vvolodin! This issue is closed in our system. We would like your feedback on your experience with our support team and Platform.

Best regards, Teams Platform

vvolodin commented 2 years ago

Everything compiled successfully after updating to 2.4.1. Thank you.