OfficeDev / microsoft-teams-library-js

JavaScript library for use by Microsoft Teams apps
https://docs.microsoft.com/microsoftteams/platform/
Other
418 stars 191 forks source link

Deep links not working when custom app is open on Teams #1842

Open ceroles opened 11 months ago

ceroles commented 11 months ago

We are currently using deeplinking in our Teams custom app for users to be able to open directly to a specific tab/page.

We are noticing an issue wherein if the custom app is already open on the Teams app, and a deeplink to that custom app is selected, it results in the following error Untitled

Replicated on iPad iOS version 16.5.1, Teams versions 5.12.1 and 5.12.0

May you please help check and confirm the issue? Thank you.

ghost commented 11 months ago

Hi ceroles! Thank you for bringing this issue to our attention. We will investigate and if we require further information we will reach out in one business day. Please use this link to escalate if you don't get replies.

Best regards, Teams Platform

Meghana-MSFT commented 11 months ago

@ceroles - Could you please confirm if you are using https://teams.microsoft.com/l/app/<appId> to deeplink to your app or using deeplink to a tab? Please share your deeplink.

We are noticing an issue wherein if the custom app is already open on the Teams app

Could you please let us know where are you opening the custom app? Could you please share video of the issue?

ceroles commented 11 months ago

We have a page that has a button which redirects to Teams app, using deeplinks of the following format: msteams:/l/entity/<appId>/<entityId>?context={"subEntityId":"<subEntityId>"}

We are also able replicate with the ff format though: https://teams.microsoft.com/l/entity/<appId>/<entityId>

We either click on the link or paste it in the browser. We were also able to replicate this on the Approvals app, here is a video of it: https://github.com/OfficeDev/microsoft-teams-library-js/assets/118153014/e4203eca-9ecb-4f5f-a213-c908e663c1e8

Meghana-MSFT commented 11 months ago

Thank you for the additional details, we will check this and get back to you.

Meghana-MSFT commented 11 months ago

We are able to repro this issue, we will check internally and get back to you.

Meghana-MSFT commented 11 months ago

@ceroles - Could you please confirm if the app is installed. If the app is installed, the deeplink should work. Could you please confirm this?

ceroles commented 11 months ago

Hi, yes the app is installed such that it is already added and available in the user's Teams. Not sure if there is a difference, but note that our app is added to the organization by the Teams administrator through the admin center, and is not published publicly on the Teams app store. Thank you.

kafka-yu commented 10 months ago

we also face this issue.. https://github.com/OfficeDev/microsoft-teams-library-js/issues/1883

ceroles commented 10 months ago

May we just follow up on the status of the issue? Thank you. cc @Meghana-MSFT

Meghana-MSFT commented 10 months ago

@ceroles - Apologies for the delay, we are checking the status of this issue with engineering team. We will get back to you.

ceroles commented 9 months ago

Hi, just wondering if there's any update on the status of this? Thank you. cc @Meghana-MSFT

Meghana-MSFT commented 9 months ago

Unfortunately, we do not have any update. Team is still investigating this issue. We will keep you posted once we get any update. Thank you for your understanding.

mudeboo commented 9 months ago

hello We also have the same problem. Do you have a timeline for resolving the issue? Is @Meghana-MSFT an MS engineer?

Meghana-MSFT commented 9 months ago

We checked this at our end with approvals app and it seems to be working fine. Engineering team has also verified that it is working.

Could you please try with the approvals app deeplink - https://teams.microsoft.com/l/entity/7c316234-ded0-4f95-8a83-8453d0876592/approvals

ceroles commented 8 months ago

We are no longer able to replicate the issue on iPad iOS version 16.6, Teams versions 5.17.1. However, in checking we have come across another issue: #1980. Thank you.

mudeboo commented 8 months ago

hello This error occurs in Windows Teams Client. Also, Javascript Alert and Confirm do not run in New Teams.