OfficeDev / microsoft-teams-library-js

JavaScript library for use by Microsoft Teams apps
https://docs.microsoft.com/microsoftteams/platform/
Other
429 stars 197 forks source link

Teams bot SSO link null reference error #1914

Open catmanjan opened 1 year ago

catmanjan commented 1 year ago

We have just set our Teams bot up in another tenant and they are getting this error when they try to do an SSO sign in - any ideas how to troubleshoot?

The bot is working fine in our tenant BTW

image

microsoft-github-policy-service[bot] commented 1 year ago

Hi catmanjan! Thank you for bringing this issue to our attention. We will investigate and if we require further information we will reach out in one business day. Please use this link to escalate if you don't get replies.

Best regards, Teams Platform

catmanjan commented 1 year ago

From this doco I believe we shouldn't even be asked for sign in: https://learn.microsoft.com/en-us/microsoftteams/platform/bots/how-to/authentication/bot-sso-code?tabs=cs1%2Ccs2%2Ccs3%2Ccs4%2Ccs5&pivots=bot-app

image

Prasad-MSFT commented 1 year ago

Hi @catmanjan - If you are having SSO configured in your app then you need to configure these settings in your appsettings.json file of your code.

"MicrosoftAppType": "MultiTenant", // Set this to SingleTenant if you are using a single tenant app registration
"MicrosoftAppTenantId": "common" // Set your tenantId here if you are using single tenant app registration.
catmanjan commented 1 year ago

@Prasad-MSFT yes we have these, we already have sso working in another tenant but this new tenant when I click sign in I get a JavaScript error above

Prasad-MSFT commented 1 year ago

@catmanjan - From the console error it is not quite clear what's the cause of the issue? Is it happening only with this tenant?

catmanjan commented 1 year ago

@Prasad-MSFT this is the first new tenant we have set up our integration in - how can I get more information for you to diagnose this issue? We see nothing in our own logs

Prasad-MSFT commented 1 year ago

@catmanjan - Is it possible for you to share the tenant id and app details, so that we can have a look at our end? You can send a mail to microsoftteamsdev@microsoft.com

catmanjan commented 1 year ago

@Prasad-MSFT 5166d23c-0135-4648-aca2-25cb29d6c70f

Prasad-MSFT commented 1 year ago

@catmanjan - I mean to say, we need the tenant credentials and app details to login to the account and check the issue.

catmanjan commented 1 year ago

@Prasad-MSFT I've sent those through, to reproduce the issue go to Teams and type @Ingress Search in search bar and select enterprise search, try to sign in from there

Prasad-MSFT commented 1 year ago

@catmanjan - We tried to repro this issue using the credentials provided and observed the same behaviour. image

We request to share the sample code you used, so that accordingly we can raise a bug for this.

catmanjan commented 1 year ago

@Prasad-MSFT I'll send our bot source code to that email, we don't have a sample code because this is a real app

Prasad-MSFT commented 1 year ago

@catmanjan - Thanks for sharing the source code. We have raised a bug for the same. We will inform you once we get any further update from engineering team.

catmanjan commented 1 year ago

@Prasad-MSFT any update?

Prasad-MSFT commented 1 year ago

@catmanjan - At the moment, we have not received any updates from the engineering team. However, we are actively communicating with them to stay updated on the progress. As soon as we receive any updates from them, we will notify you in this thread. Thank you!

catmanjan commented 1 year ago

@Prasad-MSFT @ChetanSharma-msft any update? This is a big blocker for us...

Prasad-MSFT commented 1 year ago

Apologies @catmanjan, we are actively communicating with engineering team to stay updated on the progress. We have also made them aware of the seriousness of the issue. As soon as we receive any updates from them, we will notify you in this thread.

Thank you!

catmanjan commented 1 year ago

@Prasad-MSFT can we get an update? This is a massive issue

Prasad-MSFT commented 11 months ago

@catmanjan - We are actively communicating with them to stay updated on the progress. We have also made them aware of the seriousness of the issue. As soon as we receive any updates from them, we will notify you in this thread. Thank you!

catmanjan commented 11 months ago

@Prasad-MSFT any update on this?

Prasad-MSFT commented 11 months ago

@catmanjan - Apologies. We have not received any updates from the engineering team. As soon as we receive any updates from them, we will notify you in this thread. Thank you!

catmanjan commented 11 months ago

@Prasad-MSFT its been months, how can we escalate this?

Prasad-MSFT commented 10 months ago

@catmanjan - Apologies. Currently there is no updates from the engineering team. We have increased the severity and escalated internally. We will inform you once we have further update. Thanks!

catmanjan commented 10 months ago

@Prasad-MSFT please can we get an update?

Prasad-MSFT commented 9 months ago

Apologies, till now we have not received any updates from the engineering team. We have also made them aware of the seriousness of the issue. As soon as we receive any updates from them, we will notify you in this thread.

Thank you!

Prasad-MSFT commented 5 months ago

Hi @catmanjan - Could you please let us know whether you are still able to repro this issue or not?

catmanjan commented 4 months ago

@Prasad-MSFT yes, 9 months later it still doesn't work