search

OfficeDev / microsoft-teams-library-js

JavaScript library for use by Microsoft Teams apps
https://docs.microsoft.com/microsoftteams/platform/
Other
417 stars 191 forks source link

Tab Removal button still gets enabled after 5secs even the setValidityState is false #2363

Open aniketrai opened 1 week ago

aniketrai commented 1 week ago

Context - Removing a tab (Configurable Tab)

The text was removed which says that Remove button will be enabled after 5 secs. Does this mean this feature is implemented?

If so, I am still facing the issue. I am making the button disable by pages.config.setValidityState(false); but still it gets enabled after 5 secs.

Commit - https://github.com/MicrosoftDocs/msteams-docs/pull/10538

Expected - If using pages.config.setValidityState(false); the remove button should not be enabled.

Actual - Remove button is still getting enabled after 5 secs

Meghana-MSFT commented 1 week ago

Thank you for reporting this, we will check this and get back to you.

aniketrai commented 1 week ago

Any update?

aniketrai commented 4 days ago

Hi @Meghana-MSFT, can you please update. This we need it urgently. We are about to rollout our app to customers.

Meghana-MSFT commented 4 days ago

@aniketrai - We are checking this internally; we will get back to you.

Update : Engineering team has confirmed that this behavior is by design. We intentionally light up the "Remove" button after 5 seconds because we do not want users to ever lose the ability to remove a tab.