search

OfficeDev / microsoft-teams-ui-component-library

Component library enhanced experiences styled for use in Microsoft Teams custom applications.
MIT License
127 stars 30 forks source link

Outdated sample app #104

Open restfulhead opened 2 years ago

restfulhead commented 2 years ago

https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/tab-ui-templates/ts

Expected: The sample up uses a recent version.

Actual: Dependencies from almost a year ago:

"@fluentui/react-northstar": "^0.51.3",
"@fluentui/react-teams": "0.1.0-alpha.10",
"@microsoft/teams-js": "^1.8.0",
"@uifabric/example-data": "^7.1.5",

Tried upgrading, but causes errors such as Type 'Element' is not assignable to type 'TWidgetContent'. This seems to be related to https://github.com/OfficeDev/microsoft-teams-ui-component-library/issues/101. In there it says it's not supported, yet the sample code attempts to do this.

Can the sample app be upgraded or is there another app that I could take a look at that isn't outdated?

landonconover commented 2 years ago

For anyone who is looking at this, currently, in the most recent version of Teams UI Component Library, the dashboard is meant only to be used for chart types, as mentioned in issue #101 this is by design. To fix this issue, the work that needs to be done is to use the placeholder object type instead of the current React Node. It would also be helpful to update the type documentation to reflect that.