search

OfficeDev / microsoft-teams-ui-component-library

Component library enhanced experiences styled for use in Microsoft Teams custom applications.
MIT License
127 stars 31 forks source link

Upgrade Northstar dependency #116

Closed thure closed 2 years ago

thure commented 2 years ago

This should include handling the change in @fluentui/react-icons which removed inherent dimensions from SVGs. It's causing some confusion: #80, #115.

Let's fix that.

Codesandbox

IliasLoudrassi commented 2 years ago

+, I hope it will be solved soon.

thure commented 2 years ago

@ilyassloudrassi, this is an excellent first issue. If you derive value from this package, we’d welcome a PR from you (or anyone) that resolves this ✨

IliasLoudrassi commented 2 years ago

Unfortunately the update solved only the icons in the list component, in Wizard icons for completing the steps still not showing + Checkbox selectivity doesn't show up on List rows.

thure commented 2 years ago

What specific version of the alpha exhibited those issues? We bumped the version a few times today, and I'm not seeing any regressions with icons as of 6.0.0-alpha.18.

If you're using that version and still seeing issues, could you provide a CodeSandbox so we can investigate?

thure commented 2 years ago

Closing this, as actually any follow-up should be in a new issue regarding the specific problem given no further upgrade to Northstar is applicable.

@ilyassloudrassi if you are observing issues in 6.0.0-alpha.18, please file a new issue with the CodeSandbox. Thanks!