value.path is undefined when using Communication component with custom image

OfficeDev / microsoft-teams-ui-component-library

Component library enhanced experiences styled for use in Microsoft Teams custom applications.

MIT License

127 stars 30 forks source link

value.path is undefined when using Communication component with custom image #130

Open leocabeza opened 2 years ago

leocabeza commented 2 years ago

Update:

This is breaking in macOS, using Firefox or Safari. But is working on Chrome and Brave

The error points to somewhere around here: https://github.com/OfficeDev/microsoft-teams-ui-component-library/blob/main/src/lib/isImage.tsx#L18

Reproduction

You can already see this in https://dev.teams.microsoft.com/storybook/main/index.html?path=/story/components-communication--custom

Expected Behavior

To show custom image

Actual Behavior

It doesn't show image and throws an error

leocabeza commented 2 years ago

More info: This is breaking in macOS, using Firefox or Safari. Chrome works though

thure commented 2 years ago

Hi @leocabeza, apologies for the delay.

I can see what you're talking about, thanks for catching this. Unfortunately I don't think the maintainers will have the bandwidth to address this very soon, though if you're able to propose a pull request we'd be glad to review it.