OfficeDev / microsoft-teams-ui-component-library

Component library enhanced experiences styled for use in Microsoft Teams custom applications.
MIT License
127 stars 30 forks source link

Question - What is the correction version that can be used in production #145

Closed asith-w closed 2 years ago

asith-w commented 2 years ago

Reproduction

I am bit confused about the version that works for production app . in read me file it asks to use below

react@^16.8.0
react-dom@^16.8.0
@fluentui/react-northstar@^0.54.0

I gets below errors and want to use update to date react-northstar version. what is the best version that compatible with latest react-northstar (currently it is 0.63.0)

npm ERR! While resolving: @fluentui/react-teams@6.0.0
2022-06-20T12:57:21.2537783Z   npm ERR! Found: @fluentui/react-northstar@0.60.1
2022-06-20T12:57:21.2539917Z   npm ERR! node_modules/@fluentui/react-northstar
2022-06-20T12:57:21.2541744Z   npm ERR!   @fluentui/react-northstar@"^0.60.1" from the root project
2022-06-20T12:57:21.2546372Z   npm ERR! 
2022-06-20T12:57:21.2549503Z   npm ERR! Could not resolve dependency:
2022-06-20T12:57:21.2550142Z   npm ERR! peer @fluentui/react-northstar@"^0.56.0" from @fluentui/react-teams@6.0.0
2022-06-20T12:57:21.2551993Z   npm ERR! node_modules/@fluentui/react-teams
2022-06-20T12:57:21.2562766Z   npm ERR!   @fluentui/react-teams@"^6.0.0" from the root project
2022-06-20T12:57:21.2569564Z   npm ERR! 
2022-06-20T12:57:21.2570195Z   npm ERR! Conflicting peer dependency: @fluentui/react-northstar@0.56.0
2022-06-20T12:57:21.2570778Z   npm ERR! node_modules/@fluentui/react-northstar
2022-06-20T12:57:21.2571690Z   npm ERR!   peer @fluentui/react-northstar@"^0.56.0" from @fluentui/react-teams@6.0.0
2022-06-20T12:57:21.2572993Z   npm ERR!   node_modules/@fluentui/react-teams
2022-06-20T12:57:21.2573570Z   npm ERR!     @fluentui/react-teams@"^6.0.0" from the root project
thure commented 2 years ago

Hi @asith-w, apologies for the confusion, I think the Readme may be out of sync with the package.json.

The correct source of truth is the package.json, as such please use @fluentui/react-northstar at 0.62.0 for the best experience. We optimistically support other patches, but can’t guarantee.