search

OfficeDev / office-js-docs

[ARCHIVED] Microsoft Office Add-ins API Reference Documentation
https://docs.microsoft.com/javascript/api/overview/office
398 stars 247 forks source link

Added session parameter #1490

Closed rahul-mi closed 6 years ago

AlexJerabek commented 6 years ago

Hi @rahul-mi, can you merge these twenty related PRs into one? That would make it easier to review and process.

We're also in the process of transferring the contents of this repo to another. Having this patch in one PR helps ensure nothing gets dropped during the migration.

Thanks!

rahul-mi commented 6 years ago

Hi Alex

I wanted to do that but didn’t know how. Could you help me with merging these into one PR?

Also, there is only single word changes in each PR. So if you could review and process this time, I’ll really appreciate it and can keep it in mind for future.

Let me know.

Regards Rahul Mittal

From: Alex Jerabek notifications@github.com Sent: Tuesday, July 31, 2018 11:27 PM To: OfficeDev/office-js-docs office-js-docs@noreply.github.com Cc: Rahul Mittal (VISIO) rahulmi@microsoft.com; Mention mention@noreply.github.com Subject: Re: [OfficeDev/office-js-docs] Added session parameter (#1490)

Hi @rahul-mihttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frahul-mi&data=02%7C01%7Crahulmi%40microsoft.com%7C536fa53e8cb341f2c21308d5f70f0b12%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636686566348747503&sdata=iTUJH6PI6w6VKz%2FuQtv9Vi0FgGIYk5gV0m13JJGKjcw%3D&reserved=0, can you merge these twenty related PRs into one? That would make it easier to review and process.

We're also in the process of transferring the contents of this repo to another. Having this patch in one PR helps ensure nothing gets dropped during the migration.

Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FOfficeDev%2Foffice-js-docs%2Fpull%2F1490%23issuecomment-409311689&data=02%7C01%7Crahulmi%40microsoft.com%7C536fa53e8cb341f2c21308d5f70f0b12%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636686566348747503&sdata=xPxnyW1JGMngnULSiG0F8Unv%2BY8G0HZfig43zD1m%2BJE%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAVWx-l-iPBIQIcTUWD6PCtRk6NQsb2Azks5uMJp3gaJpZM4Vomcs&data=02%7C01%7Crahulmi%40microsoft.com%7C536fa53e8cb341f2c21308d5f70f0b12%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636686566348757513&sdata=Tp7MQFGQYrs6f6H94iH68D0Dyp0mGU6ZMPFFXfM8D%2FY%3D&reserved=0.

AlexJerabek commented 6 years ago

@rahul-mi If you want to have a PR with multiple files, you'll need to fork and clone the repo, edit the files on your local machine, commit and push the changes, and then submit the PR to GitHub.

However, as I eluded to earlier, this repo will soon not be the source for Office Add-ins reference documentation. Our new repo uses DefinitelyTyped as the source of truth and a snippet file in the repo for examples. Effectively, we're going to have to change the new repo's examples to match your new run usage.

Of course, I'm happy to do that for you (since the new repo is still private). I would like to know what the reason for this change is. I believe most other Office Add-in snippets (of not all) use function run<T>(batch: (context: [hostname].RequestContext) => Promise<T>): Promise<T>;. Why use the session overload if the example doesn't need it?

Thanks!

AlexJerabek commented 6 years ago

Hi @rahul-mi, I've checked these changes in. I also have the content ported to the new reference docs. That repo is still private, but I'll link you to the new doc site when it's up.