search

OfficeDev / office-js-helpers

[ARCHIVED] A collection of helpers to simplify development of Office Add-ins & Microsoft Teams Tabs
MIT License
126 stars 56 forks source link

Fix Utilities.host/Utilities.platform #135

Closed Zlatkovsky closed 5 years ago

Zlatkovsky commented 5 years ago

Before this fix, "host" would return "undefined" instead of web. This also fixes #133

Zlatkovsky commented 5 years ago

@sumurthy , @akrantz , @LouMM : could you please review, merge in, and release a new package? This addresses both the customer-reported issue #133 from this morning, and also a longstanding issue I'd seen in Script Lab (which is why we were stuck on an old version of 0.7.4 rather than upgrading to the latest).

Thanks!

Zlatkovsky commented 5 years ago

@akrantz , I see you merged the branch into master. Does that kick off an npm publish automatially? Or if not, can you or @sumurthy do one manually? (Note, you may also want to merge in https://github.com/OfficeDev/office-js-helpers/pull/125 at the same time, which is another trivial PR, and publish an update that contains both -- I know Yutao has been waiting on it for several months now...)

akrantz commented 5 years ago

@Zlatkovsky I actually don't know. I don't normally work in this repository.