search

OfficeDev / office-js-helpers

[ARCHIVED] A collection of helpers to simplify development of Office Add-ins & Microsoft Teams Tabs
MIT License
126 stars 57 forks source link

"Unable to delete 'Microsoft' from storage" with version 1.0.2 on IE11 and Edge #76

Open blandine opened 6 years ago

blandine commented 6 years ago

Hi,

I use office-js-helpers in an Excel addin. The authentication helpers works well the first time on IE11 and Edge. But after reloading the addin, this errors appears in the console and the addin can't load : 

Unable to delete 'Microsoft' from storage

I don't know yet if it's related but I can't get my addin work anymore in Excel. Everything is ok in Chrome and Firefox. Thanks for your time

wilsonyqm commented 6 years ago

we have the same issue, our workaround is trying to cache the error and do global.localStorage.clear(). it's failing on https://github.com/OfficeDev/office-js-helpers/blob/master/src/authentication/token.manager.ts#L81, the token expired, but the provider doesn't exist before it tries to delete.

WrathOfZombies commented 6 years ago

There's a bug in the expiry logic #80 and this might be related to that. I'll fix it shortly.

meslater1030 commented 6 years ago

Hi - I'm having this same issue. I noticed that @blandine made a commit to @neoreeds's fork but that no pull request was opened. @WrathOfZombies What's the current recommended fix for this issue?

Mathyaku commented 5 years ago

@wilsonyqm your trick still working.