OfficeDev / office-js-helpers

[ARCHIVED] A collection of helpers to simplify development of Office Add-ins & Microsoft Teams Tabs
MIT License
126 stars 56 forks source link

Uncaught Error: Cannot close dialog #81

Open P4trik opened 6 years ago

P4trik commented 6 years ago

Hello, I implemented the office-js-helpers into my React Outlook Add-In. I get the following error message:

image

The dialog with the token opens up and I already see the token as GET parameter (https://localhost:3000/#access_token=eyJ0eXAiO...).

I added the "https://localhost:3000" URL in the manifest file:

`

https://localhost:3000
<AppDomain>https://login.windows.net</AppDomain>
<AppDomain>https://login.microsoftonline.com</AppDomain>

`

If I close the token window, I get this error message in my root Add-In site:

image

WrathOfZombies commented 6 years ago

Let me get back to you on this one.

elegault commented 6 years ago

+1; React project as well

koskila commented 6 years ago

+1; React project here too.

honb commented 4 years ago

I'm getting the same issue in Outlook web. (ReactJS & generator-office). Did you guys find a solution?

It opened a dialog with access token there but do not close the dialog. When I close dialog manual then it shown an error

image

image

image

Will this library work on Desktop app as well? I meant this add-in will be used in Outlook desktop app

lindalu-MSFT commented 4 years ago

Hi all, I will try to track down some folks on the product team to help with this issue! It's a little beyond my technical expertise, but I will do my best to find the right engineers to assist.

nilslockean commented 4 years ago

Same here! CRA project. Tried downgrading office-js-helpers to 1.0.0 and it seems to have solved the problem...

lindalu-MSFT commented 4 years ago

@nilslockean I just assigned a few Outlook add-in experts. @jasonjoh @ElizabethSamuel-MSFT @Reezaali, seems there are issues with the sample in this repo. This is not a repo that we actively monitor. But based on the issues and PRs here, and the fact that customers use these Helpers, perhaps we should be?

lindalu-MSFT commented 4 years ago

@nilslockean Hey, I just spoke in person with one of our PMs. Sadly, we are in the process of shutting down this repo and archiving it and there are no resources to assign to it. I will leave the folks I tagged in case they have any quick insights for you! Cheers, lindalu