search

OfficeDev / office-js

A repo and NPM package for Office.js, corresponding to a copy of what gets published to the official "evergreen" Office.js CDN, at https://appsforoffice.microsoft.com/lib/1/hosted/office.js.
https://learn.microsoft.com/javascript/api/overview
Other
676 stars 95 forks source link

When DisplayName string for Excel add-in is too long horizontal scroll bar appears, close button is moved and not interactable #1078

Closed Domen122 closed 3 years ago

Domen122 commented 4 years ago

Expected Behavior

Longer strings are wrapped in ellipsis and close button is working correctly

Current Behavior

When we have long Addin name it isn't wrapped in any way which results in horizontal scroll bar. Also due to this addin close button is moved below the string and becomes not interactable

Steps to Reproduce, or Live Example

  1. Create manifest for addin with long
  2. Add the addin to Excel ribbon
  3. Click on the addin to open it
  4. Notice the scrollbar
  5. Try to close the addin by clicking on the "x" button

Context

Allowing end-user to customize the manifest may lead to situation like this when he is unable to close the addin because the button is not interactable

Your Environment

Useful logs

TooLongName

ElizabethSamuel-MSFT commented 4 years ago

@Domen122 Sorry that you hit this issue and thanks for reporting it.

@lumine2008 Can you take a look?

Thanks.

lumine2008 commented 4 years ago

Thanks @ElizabethSamuel-MSFT , I think this should be UI areas, So let's assign to Lillian @lliu113

lliu113 commented 3 years ago

@Domen122 - thanks for reporting this, sorry for the very belated response. I'm unable to repro this on my end - the long title introduces the horizontal scroll but the "x"/close button still works. Can you confirm whether you're still seeing this issue?

Thanks!

ghost commented 3 years ago

This issue has been automatically marked as stale because it is marked as needing author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for your interest in Office Add-ins!

ghost commented 3 years ago

This issue has been closed due to inactivity. Please comment if you still need assistance and we'll re-open the issue.