search

OfficeDev / office-js

A repo and NPM package for Office.js, corresponding to a copy of what gets published to the official "evergreen" Office.js CDN, at https://appsforoffice.microsoft.com/lib/1/hosted/office.js.
https://learn.microsoft.com/javascript/api/overview
Other
688 stars 94 forks source link

"Admin Managed" add-ins not usable when third-party cookies are blocked #1958

Closed christian-sap closed 6 months ago

christian-sap commented 3 years ago

Provide required information needed to triage your issue

If you block the third-party cookies in your browser (for example in Chrome or Edge) then the "Admin Managed" Add-ins can not be used anymore.

Your Environment

Expected behavior

Admin Managed Add-ins should work in Excel Online even if third-party cookies are blocked in the browser.

Current behavior

Admin Managed Add-ins do not work.

Steps to reproduce

  1. Block third party cookies in your browser (e.g. Chrome, Edge)
  2. Launch Excel Online
  3. Go to "Insert" -> "Office Add-ins" -> "Admin Managed"

When third party cookies are blocked the admin managed add-ins are not shown in the dialog (see attached video).

Link to live example(s)

See attached screen cams. One is where third party cookies are allowed and one is with blocked third party cookies.

Context

Useful logs

I see the following error in the console which could be the root cause of the issue: "Refused to display 'https://login.microsoftonline.com/' in a frame because it set 'X-Frame-Options' to 'deny'."

christian-sap commented 3 years ago

https://user-images.githubusercontent.com/79985386/123375049-6b748900-d588-11eb-9b42-a2d3eba96e9f.mp4

https://user-images.githubusercontent.com/79985386/123375060-70393d00-d588-11eb-8106-d63952809ce6.mp4

lindalu-MSFT commented 3 years ago

Thanks for the useful videos showing how to repro. I've assigned to @keyur32 to help triage this!

christian-sap commented 3 years ago

Hi @keyur32 and @lumine2008 , did you have time to check this issue? It is a complete blocker of using admin managed add-ins when customers have blocked third-party cookies in the browser.

keyur32 commented 3 years ago

Thank you for the report and apologies for the inconvenience. We can repro and team is investigating this limitation. Internal tracking #: 4774608

christian-sap commented 3 years ago

Hi @keyur32 , is there any update? Add-ins are not working if 3rd party cookies are disabled. This will be a blocker for some of our customers.

christian-sap commented 3 years ago

Hi @keyur32 , is there any result of the investigation?

RuoyingLiang commented 3 years ago

Hi @christian-sap Feature team is working on a possible solution and don't have a timeline yet. Will update this thread with any news.

christian-sap commented 2 years ago

Hi @RuoyingLiang , no update since 4 months now. Are you planning to fix this?

christian-sap commented 2 years ago

Hi @keyur32 any plans to fix this? There are no updates since almost 1 year.

keyur32 commented 1 year ago

Assigned to @AkhileshShah-MS and @RuoyingLiang for updates.

stevebeauge commented 9 months ago

In 2024 3rd part cookies are going to be disabled by chromium browsers (long time ago also by Firefox).

Can you share update regarding this ticket ?

Maybe related:

4tti commented 8 months ago

I am interested too, how is it going to be with Office add-ins and excel/word/ppt online within the chrome?

mailchecktool-admin commented 6 months ago

@keyur32 @exextoc I'm also interested in what @stevebeauge is saying. Even after third-party cookies are disabled, can Office add-ins still be used as usual?

For reference, here is the information based on my findings. After disabling third-party cookies in the Chrome browser settings and conducting tests, it appears that the add-ins can still be used normally. Since the add-in was built using the local storage API, I anticipated there might be an impact, but no issues arose.

However, when the same test was conducted before 2023, there were issues. (The loading icon remained in the header section of the email composition screen, and the add-in did not execute.)

mailchecktool-admin commented 6 months ago

@keyur32 @exextoc Multiple developers have been inquiring, but why aren't they responding? We'd like to understand how the discontinuation of third-party cookies will impact Office Add-ins. Could we please get the latest information?

LuyiH commented 6 months ago

Hi Developers, Thank you for your questions. For now, we recommend using MSAL, which should help solve most of the problems caused by third-party cookies being disabled. Detail progress here. If you have any other specific questions, please feel free to open a new ticket.

LuyiH commented 6 months ago

Close with fix.

suuunly commented 5 months ago

This is not a good solution. Because the Office Dialog Api alone is non-responsive, because of third party cookies. Why do you utilise third-party cookies for a plain dialog window anyways?