OfficeDev / office-js

A repo and NPM package for Office.js, corresponding to a copy of what gets published to the official "evergreen" Office.js CDN, at https://appsforoffice.microsoft.com/lib/1/hosted/office.js.
https://learn.microsoft.com/javascript/api/overview
Other
687 stars 94 forks source link

insertWorksheetsFromBase64 not working with Sensitivity label #2081

Closed ALDriehuis closed 3 years ago

ALDriehuis commented 3 years ago

Hi Guys,

We are creating an Excel addin and we are now in the phase of testing it worldwide.

Our tool makes use of the insertWorksheetsFromBase64 (it is so cool!!!) and it works in most cases for us. BUT we found that people using Miscrosoft's Sensitivity Label feature, are getting an error ('There was an internal error while processing the request.') whenever this function is called. The template that we load with this function, did not change! They get this error in the Desktop version of Excel, it is working perfectly in the online version!

Expected Behavior

We expect that a template is downloaded and loaded into our workbook and that it works on Desktop and Online.

Current Behavior

We see that the function 'insertWorksheetsFromBase64' throws an error 'There was an internal error while processing the request.' BUT only for our users with Sensitivity Label activated.

Next to that, we see that it is working for Online and failing for Desktop. Again, same code, same template that we try to load.

Steps to Reproduce, or Live Example

Unfortunately we have nothing to reproduce it because our region is not using Sensitivity Labels...yet.

Context

We are currently testing worldwide, and the plan is to go live next month. This issue is our top priority this moment.

We provide an Excel Addin to our users, worldwide, where they need to enter portfolio data.

Our solution, downloads templates and adds them to the workbook that the user is using. The users enters their values and they can save the data.

We got this issue since last week. But it turns out that some testers were also invited this week to test the Sensitivity Label feature.

Your Environment

Useful logs

keyur32 commented 3 years ago

Cool use case. Assigning to @lumine2008 to help investigate.

qinliuMSFT commented 3 years ago

Hi @ALDriehuis, thank you for logging this issue. I'm trying to repro this problem by using the sample snippet Insert external worksheets in Script Lab. But I'm not able to repro. My repro file's permission like below. image

Could you please check and compare my snippet and file permission with yours? I'm wondering if my repro environment is right?

ALDriehuis commented 3 years ago

Hi,

First or all, thanks for looking into this case.

But I do not know how to answer your question. What do you mean with repro environment and how can I check these settings.

Maybe good to tell. Our company is doing a test in (only) Brazil with Sensibility Label. In my region we are not using it, and I have no experience on this at all. But if you could provide me some additional information on how to set it up on my local machine then I am more than happy to do that!

qinliuMSFT commented 3 years ago

Hi @ALDriehuis, sorry the "environment" may cause the misunderstanding. I'm talking about the snippet/sensibility permission, etc. Could you please help answer the following questions?

  1. Could you please give us a sample snippet to help repro? I'm using the sample snippet Insert external worksheets in Script Lab, I'm wondering if it's enough to repro this issue?
  2. Could you please confirm the system locale is English or Portuguese (Brazil) on the testing machine?
  3. Could you please check the sensibility permission by clicking "View Permissions..." once you open a workbook with Sensibility Label?
ghost commented 3 years ago

This issue has been automatically marked as stale because it is marked as needing author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for your interest in Office Add-ins!

ALDriehuis commented 3 years ago

Hi,

Many thanks for your time spend until now, but I suggest we close the issue right now. I do not get any feedback from our team and because I am living in a region where our company has not yet rolled out Sensitivity Labels, I can not supply any additional data. Many thanks again!

Lou