search

OfficeDev / office-js

A repo and NPM package for Office.js, corresponding to a copy of what gets published to the official "evergreen" Office.js CDN, at https://appsforoffice.microsoft.com/lib/1/hosted/office.js.
https://learn.microsoft.com/javascript/api/overview
Other
669 stars 95 forks source link

Changing the "From" address clears signatures and does not raise any events #2211

Open barclayadam opened 2 years ago

barclayadam commented 2 years ago

Message from office-js bot: We’re closing this issue because it has been inactive for a long time. We’re doing this to keep the issues list manageable and useful for everyone. If this issue is still relevant for you, please create a new issue. Thank you for your understanding and continued feedback.

Overview

We are adding signatures to emails in the MessageCompose launch event. The issue is that if during the composing of an email, the user changes the "From" address the signature is removed and the add-in gets no notification of the change and is in fact completely stopped.

Your Environment

Expected behavior

Not sure about the best design from Outlook side, but I would like to see:

Current behavior

Any existing signature is removed and the add-in is stopped.

Context

As per the outline, the solution we are proving is signature management and one scenario we would like to support is "send on behalf of", where a user may have the option of sending from multiple email addresses.

This is currently impossible to support in an automated way, with only the task pane acting as a backup that allows users to manually add their signatures

exextoc commented 2 years ago

Thanks for reporting this issue regarding setSignature and changing the From address. We have put the feature request for a From changed event in on our backlog. We unfortunately have no timelines to share at this point.

Internal tracking id: Office: 5256718

barclayadam commented 2 years ago

Thank you @exextoc.

Without this feature, it is impossible for us to do anything in this case and, especially with the signature being removed, it feels broken for our users.

Is not killing the add-in something you would consider separately from the more useful event being added as a feature? If the add-in was not completely stopped we would be able to use current workaround

barclayadam commented 2 years ago

Hi @exextoc

I was following up to see if there is any movement on the feature request you mentioned, 5256718? In addition is there any potential for changes / bug fixes as discussed above that could, even without a full event implementation, potentially allow us to have workarounds continue to work (i.e. do not kill the add-in, or run the OnMessageCompose event again as Outlook seems to treat changing the From address like a new event).

In addition, if you consider the From event can I please ask that you consider the scenario of a user choosing the same email address when selecting 'From'.

The reason is that at the moment if you hit the 'From' button and select the current user the signature will be removed, but NO event is raised in any way. We have a workaround possible in our task pane using a loop to check the From address has changed to allow us to re-insert a signature, but this never fires because From never changes but the signature is removed.

I'm not sure if the above should be considered separately from this issue?

exextoc commented 2 years ago

We are currently reviewing this scenario to determine the right approach(es) here. There are multiple cases that we have to consider, and what you mentioned above regarding choosing the same email address is definitely one of them.

claell commented 2 years ago

Referencing the forum with similar request: https://techcommunity.microsoft.com/t5/microsoft-365-developer-platform/outlook-web-addin-add-event-on-from-address-change/idi-p/2464795.

claell commented 5 months ago

@gergzk after closing this (after a very long time with no reaction), do you mind adding some reasoning for us?

gergzk commented 5 months ago

@claell - we are doing bulk closing of the issues that have gone dormant so that we can better focus on a smaller set of things (see note added to top of body).

claell commented 5 months ago

Oki. Should I duplicate this issue then and create it again?

claell commented 5 months ago

Or can I beg you to open this issue again, instead, as it might make actually tracking all history, arguments, ... much easier?

I'll follow your policies, of course @gergzk!

gergzk commented 5 months ago

@claell - Part of the goal here is a forcing function to check things like "does anyone still care about this." I can reopen this one.