search

OfficeDev / office-js

A repo and NPM package for Office.js, corresponding to a copy of what gets published to the official "evergreen" Office.js CDN, at https://appsforoffice.microsoft.com/lib/1/hosted/office.js.
https://learn.microsoft.com/javascript/api/overview
Other
670 stars 95 forks source link

"ADD-IN ERROR" shown wrongly in dialog #3028

Open christian-sap opened 1 year ago

christian-sap commented 1 year ago

Message from office-js bot: We’re closing this issue because it has been inactive for a long time. We’re doing this to keep the issues list manageable and useful for everyone. If this issue is still relevant for you, please create a new issue. Thank you for your understanding and continued feedback.

When opening a dialog the window wrongly shows an "ADD-IN ERROR" in some certain situations.

Your Environment

Expected behavior

The "ADD-IN ERROR" should only be shown if there is a real error.

Current behavior

The "ADD-IN ERROR" is shown if the server returns a HTTP 401 even though the browser responds correctly by showing a "Windows Security" popup where the user can log in.

Steps to reproduce

  1. Launch a dialog and redirect to another domain where the server responds with HTTP 401 and these HTTP headers: WWW-Authenticate: Negotiate WWW-Authenticate: NTLM

  2. As a result a popup is shown where the user can authenticate. This is the expected behavior.

  3. Unfortunately in the dialog window a yellow "ADD-IN ERROR" is shown which is really confusing for users. Nothing went wrong. The server returned a HTTP 401 with instructions for the browser and the browser showed the popup.

https://user-images.githubusercontent.com/79985386/206464542-08c5f257-51bc-4d4a-b601-b51b7971ff00.mp4

addinError

Link to live example(s)

No live example available.

Context

This issue occurred for one of our customers and the users always get this "ADD-IN ERROR" when authenticating to the IDP even though there is no error. This is misleading and confusing.

Useful logs

ghost commented 1 year ago

Thank you for letting us know about this issue. We will take a look shortly. Thanks.

RuizhiSunMS commented 1 year ago

Have forward this issue to the owner team.

christian-sap commented 5 months ago

Hi @gergzk, is there a reason why do not fix this issue?

gergzk commented 5 months ago

@christian-sap - we are doing some bulk cleanup of issues (based on least-recently-updated) and a few of them are false positives for closing. In practice most of this work is tracked in internal systems (not GitHub) by dev teams, and many issues get desynced (a decision or fix is made, but the result doesn't get reflected back here). We've improved this mirroring process and are cleaning up the old, open issues to help us get fully on a better path. Since this was assigned to a developer, I'll reopen it.