OfficeDev / office-js

A repo and NPM package for Office.js, corresponding to a copy of what gets published to the official "evergreen" Office.js CDN, at https://appsforoffice.microsoft.com/lib/1/hosted/office.js.
https://learn.microsoft.com/javascript/api/overview
Other
660 stars 94 forks source link

Contextual tab not appearing when using sideloading #3476

Open wh1t3cAt1k opened 1 year ago

wh1t3cAt1k commented 1 year ago

Your Environment

Expected behavior

Contextual tab appears every time you create a new workbook with the side-loaded add-in.

Current behavior

The ribbon sporadically does not appear.

Steps to reproduce

Download manifest: app.velixo.com_addin_manifest.xml.zip

Side-load it into Excel Online.

Create a new workbook (File -> New). Observe whether "Velixo NX" tab did or did not appear in the ribbon.

Repeat the File -> New process until the tab does not appear.

Context

We cannot reliably run end-to-end tests because of that issue. It may also point to a bigger stability issue inside the framework.

VIDEO DEMONSTRATION:

https://www.loom.com/share/851a801b58c147bfba7dec75fc6f614f?sid=9e819811-179e-455b-8a72-71934eb8196a

ghost commented 1 year ago

Thank you for letting us know about this issue. We will take a look shortly. Thanks.

ZYUN-MSFT commented 1 year ago

Hi @wh1t3cAt1k thanks for reaching us.

We are still investigating this issue with internal teams.\ We will keep tracking this issue and let you know if there are any updates.

m-hellesen commented 1 year ago

We will be looking into this shortly! Thanks for reporting.

wh1t3cAt1k commented 1 year ago

@m-hellesen I don't know if this is related or can assist with your investigation: I have occasionally seen errors in the console saying that requestCreateControls has already been called.

But I know for a fact that we only call it once during start-up.

Looking forward to an update from you!

wh1t3cAt1k commented 1 year ago

@m-hellesen @ZYUN-MSFT I linked another old ticket for your convenience and potentially important context.

Back then, the ribbon did not appear in store-based version of the add-in. That problem got solved some time ago.

But intermittently missing ribbon problem remains for side-loaded add-ins specifically.

m-hellesen commented 1 year ago

Thanks for the new information. I am still looking into this, but since it is sporadic, its a bit harder to trace down. Thanks for your patience.

wh1t3cAt1k commented 1 year ago

@m-hellesen please let us know if there is any update on this.

We had to reopen the linked bug: https://github.com/OfficeDev/office-js/issues/3052 - the problem still seems replicable in Excel Online even for store-based add-ins.

The root cause might be the same.

gmichaud commented 11 months ago

I'm constantly seeing this problem with Excel Online when using a store based add-in.