OfficeDev / office-js

A repo and NPM package for Office.js, corresponding to a copy of what gets published to the official "evergreen" Office.js CDN, at https://appsforoffice.microsoft.com/lib/1/hosted/office.js.
https://learn.microsoft.com/javascript/api/overview
Other
641 stars 92 forks source link

After publishing a new version on the partner center, user's Excel application crashes when attempting to update the add in #4423

Closed hdwatts closed 3 days ago

hdwatts commented 1 week ago

Provide required information needed to triage your issue

Your Environment

Expected behavior

Users press Update, and our add-in updates without issue.

Current behavior

The user pressed update, their excel crashed, and when they re-opened it it had disappeared. They then went to add-ins and were able to re-add the add-in and update successfully the second time. This has occurred across 100% of our test users so far.

Steps to reproduce

  1. Publish an update to the partner center
  2. Get prompted to update the add-in in Excel
  3. Click "Update"
  4. Excel crashes

Context

We should be able to ship updates to users without having their Excel crash. This will lead to confusing scenarios when our add-in disappears and users have to re-add it via the add-ins menu.

Useful logs

Here are the windows event viewer crash logs for one user.

Excel update crash.evtx.zip

Thank you for taking the time to report an issue. Our triage team will respond to you in less than 72 hours. Normally, response time is <10 hours Monday through Friday. We do not triage on weekends.

microsoft-github-policy-service[bot] commented 1 week ago

Thank you for letting us know about this issue. We will take a look shortly. Thanks.

shanshanzheng-dev commented 1 week ago

Hi @hdwatts Thanks for reporting. If possible, could you please provide a manifest file? Thanks.

hdwatts commented 1 week ago

@shanshanzheng-dev See below: prod-manifest.xml.zip

jargil commented 1 week ago

@hdwatts - are you able to attach WinDbg to Excel and share the memory dump when it crashes?

hdwatts commented 1 week ago

@jargil If you can provide me with steps to install the prior version from the Microsoft store I can get that for you. Unfortunately, as of now our team has all updated so I do not have a machine to test an update with.

jargil commented 5 days ago

@hdwatts - thanks for getting back.

Could you confirm the following:

Unfortunately, moving to prior versions is not a supported flow, and I cannot reproduce nor I'm aware of there being a general problem with updating of add-ins. Without a memory dump for this particular case I'll move ahead with marking this as not reproducible until we can capture more information.

shanshanzheng-dev commented 3 days ago

Hi @hdwatts, this issue should be fixed, hope you have got expected behavior. We'll closed this issue. If you have any question, please let us know. We value your feedback. Thanks.