OfficeDev / office-js

A repo and NPM package for Office.js, corresponding to a copy of what gets published to the official "evergreen" Office.js CDN, at https://appsforoffice.microsoft.com/lib/1/hosted/office.js.
https://learn.microsoft.com/javascript/api/overview
Other
667 stars 94 forks source link

Spam addin dialog is squished when viewed in Safari. #4561

Open glr0221 opened 2 months ago

glr0221 commented 2 months ago

Provide required information needed to triage your issue

Using safari browser and outlook on web, clicking on the spam addin button shows a squished dialog box.

Your Environment

Expected behavior

Dialog sizing should be consistent across all platforms.

Current behavior

Spam addin dialog is squished.

Steps to reproduce

  1. Download the sample code in : https://github.com/OfficeDev/Office-Add-in-samples/tree/main/Samples/outlook-spam-reporting
  2. Sideload manifest.xml
  3. Open Safari and login to your Outlook account.
  4. Select an email and click on the spam addin button.
  5. It looks like the one below : Screenshot 2024-06-10 at 10 05 28 PM

Link to live example(s)

NA

Provide additional details

NA

Context

Useful logs

Thank you for taking the time to report an issue. Our triage team will respond to you in less than 72 hours. Normally, response time is <10 hours Monday through Friday. We do not triage on weekends.

mobisw-msft commented 2 months ago

To report issues with Office Add-in samples (edited) please use the link here. If you're using the dialog API in your own add-in, you can set the width or height as a percentage of the viewport area, as mentioned here. This behaviour is consistent across all browsers, including Safari.

glr0221 commented 2 months ago

@mobisw-msft i don't think this is an issue on the addin sample. This is an issue for spam addin itself. That is why I posted it here. As for the size of the viewport, yes you are right that this can be adjusted if it were an iframe opened via displayDialogAsync. But unfortunately, you cannot control the size of the viewport when opening a spam addin. Thanks.

mobisw-msft commented 2 months ago

Hey @glr0221 , apologies for the confusion. Yes- this issue seems reproducible. @glr0221 ,

Thank you for reporting this issue regarding the Spam add-in. We have added this bug to our backlog. However, we have no timelines to share at this point.

Internal Tracking ID: 4655641