search

OfficeDev / office-js

A repo and NPM package for Office.js, corresponding to a copy of what gets published to the official "evergreen" Office.js CDN, at https://appsforoffice.microsoft.com/lib/1/hosted/office.js.
https://learn.microsoft.com/javascript/api/overview
Other
685 stars 95 forks source link

[Regression] RuleCollection manifest field is ignored #4668

Closed kbrilla closed 3 months ago

kbrilla commented 4 months ago

Your Environment

Expected behavior

RuleCollection is respected and for example

  <Rule xsi:type="RuleCollection" Mode="Or">
    <Rule xsi:type="ItemIs" ItemType="Message" FormType="Read"/>
  </Rule>

When addin tab is pinned, and we select appointment, rule should close addin tab. This worked till last week or so What's more tab is redirected to invalid url which causes addin to hang, and changing message does not fix it. User need to close and open tab again on correct message, which is very annoying for especially keybord focused users.

Current behavior

Addin tab stays open when pinned ignoring RuleCollection.

Steps to reproduce

  1. add this rule to manifets 
    <Rule xsi:type="RuleCollection" Mode="Or">
<Rule xsi:type="ItemIs" ItemType="Message" FormType="Read"/>
</Rule>
  2. Select message, open addin tab, pin it
  3. Select appointment
kbrilla commented 4 months ago

In Office Online addin tabs also started to act very weird at the same time

//edit: typo

rkpathak commented 4 months ago

@kbrilla Can you share the steps that needs to be done to reproduce this issue. Or create a video of the repro and share. Is this issue see on Outlook Classic or on new Outlook?

kbrilla commented 3 months ago

Preatty sure #4690 gives is about the same issue - I'm out of office now so I cant create repro, will give one after vacation

neprasad-microsoft commented 3 months ago

Hi @kbrilla #4690 is related to add-ins staying pinned in module extension tab and we can repro it. But we are unable to repro it when switching to calendar. If that is what you mean, then please share your add-in and exact repro steps. Also, is this issue on new Outlook/Legacy Outlook/ Outlook on the web or all 3?

microsoft-github-policy-service[bot] commented 3 months ago

This issue has been automatically marked as stale because it is marked as needing author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for your interest in Office Add-ins!

microsoft-github-policy-service[bot] commented 3 months ago

This issue has been closed due to inactivity. Please comment if you still need assistance and we'll re-open the issue.