OfficeDev / office-js

A repo and NPM package for Office.js, corresponding to a copy of what gets published to the official "evergreen" Office.js CDN, at https://appsforoffice.microsoft.com/lib/1/hosted/office.js.
https://learn.microsoft.com/javascript/api/overview
Other
670 stars 96 forks source link

Addin fails to load in trident (Outlook) systems when NAA-SSO authentication is used. #4842

Open glr0221 opened 3 weeks ago

glr0221 commented 3 weeks ago

I have successfully incorporated NAA-SSO authentication in my addin. I was using this sample as basis for my implementation. Everything was working fine OWA, mobile and outlook clients. However, when I tried to load the addin in TRIDENT windows-outlook clients, my addin could not be loaded.

Expected Behavior

I fully expect that NAA-SSO will not run in trident systems. However, it should not cause for the addin to not be loaded. I tried adding try-catch around 'createPublicClientApplication()' but it does not go into the 'catch' flow.

Current Behavior

Currently, if an addin adds support for NAA-SSO, and follows the sample provided, then the addin won't be loaded in trident systems.

Steps to Reproduce, or Live Example

Context

Imagine that you have an addin that runs on a lot of end points. And those endpoints are a mix of the new versions and trident systems. Currently, without NAA-SSO, your addin works great, behaves and functions as designed. Then you update your addin to support NAA-SSO, and it fails to load the trident systems.

Your Environment

Useful logs

bntv-config commented 3 weeks ago

Any update in thus issue ?

davidchesnut commented 2 weeks ago

Hi @glr0221, Unfortunately MSAL v3 (for NAA) won't run on Trident (IE webview). We're working on providing a sample that will show how to fall back to MSAL v2 so that your add-in can still authenticate and run. That is on the backlog.

Thanks! David

glr0221 commented 2 weeks ago

Hello @davidchesnut . Thanks for your response and for the sample in advance. Very much appreciated.

The other concern I have is the upcoming October 2024 deadline :

Exchange user identity tokens and callback tokens are deprecated and will begin to be turned off in October 2024. We recommend moving Outlook add-ins that use legacy Exchange tokens to nested app authentication.

Are there plans to extend the October 2024 deprecation while NAA still has some issues? Thank you.

davidchesnut commented 2 weeks ago

The timeline is in our FAQ

So just to help clarify... Only tenants with Current Channel clients will have Exchange tokens turned off in October. And then it will only be tenants we know are not using Exchange tokens. So you shouldn't see add-ins affected yet. In January 2025 is when you'll see all Current Channel tenants having Exchange tokens turned off. So January is definitely when you're going to want your add-in ready.

Cheers, David

glr0221 commented 2 weeks ago

@davidchesnut Thank you for the timeline and the link explaining it. Looking forward to get the NAA-SSO in place way before the June 2025 deadline.